Repository navigation
fix(prettier-plugin-sentences-per-line): fix position error when dealing with github flavoured markdown - #939
Merged
JoshuaKGoldberg merged 3 commits intoFeb 28, 2026
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
==========================================
- Coverage 88.35% 88.19% -0.17%
==========================================
Files 11 11
Lines 146 144 -2
Branches 40 39 -1
==========================================
- Hits 129 127 -2
Misses 16 16
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ing with github flavoured markdown
marcalexiei
force-pushed
the
position-error
branch
from
February 1, 2026 09:22
fda1c8f to
717d5c5
Compare
michaelfaith
reviewed
Feb 1, 2026
michaelfaith
left a comment
michaelfaith
left a comment
Contributor
There was a problem hiding this comment.
Thanks for jumping on this!
Contributor
Author
Well, it was a bug introduced by the rewrite of the plugin logic of #871 made by... drum roll
me! |
marcalexiei
changed the title
Contributor
Author
|
@JoshuaKGoldberg, when you have the chance, could you please review this? |
Merged
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Mar 1, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>prettier-plugin-sentences-per-line: 0.2.3</summary> ## [0.2.3](https://github.com/JoshuaKGoldberg/sentences-per-line/compare/prettier-plugin-sentences-per-line@v0.2.2...prettier-plugin-sentences-per-line@v0.2.3) (2026-03-01) ### Bug Fixes * **prettier-plugin-sentences-per-line:** fix position error when dealing with github flavoured markdown ([#939](#939)) ([26be2c6](26be2c6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Here’s a polished, clearer, and more professional version of your text. I’ve focused on grammar, readability, and technical clarity while keeping all your original details:
The following GitHub-flavored Markdown blockquote:
was causing the error:
To resolve this, this PR replaces the previous
group + breakParent + linelogic with a simplerhardlineWithoutBreakParentapproach when encounteringsentenceBreak.Additionally, I added a
testsfolder containing Markdown files along with their expected output.This makes testing easier compared to embedding strings directly in the code.
😢