Repository navigation
lifetime #69
Description
The lifetime here seem very restrictive
fp-core.rs/fp-core/src/semigroup.rs
Line 2 in 4564c42
Shouldn't that be more something like
fn combine(self, other: &Self) -> Self;
The lifetime here seem very restrictive
fp-core.rs/fp-core/src/semigroup.rs
Line 2 in 4564c42
Shouldn't that be more something like
fn combine(self, other: &Self) -> Self;
Activity
JasonShin commentedon Nov 21, 2020
Thanks for the issue @nrolland, it makes sense to accept a reference for the other param, I will update it soon