Repository navigation
docs: correct TestUtils availability and IDotnetUserSecrets remarks - #384
Merged
Merged
Conversation
…pers The package has never been published to nuget.org and is not in the packed projects, so stop telling users to `dotnet add package` it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jy23TCq1bZkdPV2GRWfspU
BuildDefinition implements only IBuildDefinition; the user secrets provider is registered only when a build definition implements IDotnetUserSecrets. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jy23TCq1bZkdPV2GRWfspU
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jy23TCq1bZkdPV2GRWfspU
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation now accurately reflects the repository’s implementation and publishing configuration.
0 open findings
What changed in this PR
Corrects documentation about internal test utilities and .NET user-secrets setup.
Changes:
- Clarifies that
Invex.Atom.TestUtilsis unpublished and internally referenced. - Corrects
IDotnetUserSecretssetup guidance and example.
| File | Description |
|---|---|
AGENTS.md |
Marks TestUtils as internal and unpublished. |
docs/developer-guide/testing.md |
Replaces invalid NuGet installation guidance. |
src/Invex.Atom.Build/Secrets/IDotnetUserSecrets.cs |
Corrects interface usage documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dec · project thread
Before: the testing guide and AGENTS.md told users to run
dotnet add package Invex.Atom.TestUtils, but that package has never been published. nuget.org returns 404 for it, and_atomdoesn't pack it. TheIDotnetUserSecretsXML docs also said the interface is included in the defaultBuildDefinition, which it isn't.After: the testing guide describes TestUtils as this repo's internal test helpers, used through a
ProjectReference. TheIDotnetUserSecretsremarks say to implement the interface explicitly and set aUserSecretsId, and the example now includes its missing base class.How: docs-only changes in
docs/developer-guide/testing.md,AGENTS.mdandsrc/Invex.Atom.Build/Secrets/IDotnetUserSecrets.cs. Packing is unchanged. These are follow-ups from the docs-standard review.Local check: the Release build passes, all net10.0 tests pass, and no snapshots changed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Jy23TCq1bZkdPV2GRWfspU
Generated by Claude Code