This repository was archived by the owner on Jul 13, 2026. It is now read-only.
Repository navigation
Add kernel item and nd_item support - #1301
Merged
Merged
Conversation
ZzEeKkAa
force-pushed
the
feature/kernel_item
branch
10 times, most recently
from
February 2, 2024 17:03
fb5b213 to
4a23fe8
Compare
diptorupd
reviewed
Feb 2, 2024
ZzEeKkAa
force-pushed
the
feature/kernel_item
branch
2 times, most recently
from
February 2, 2024 17:53
42dc605 to
793647c
Compare
ZzEeKkAa
marked this pull request as ready for review
February 2, 2024 17:53
ZzEeKkAa
force-pushed
the
feature/kernel_item
branch
from
February 2, 2024 17:55
793647c to
f3ce9a9
Compare
ZzEeKkAa
changed the title
diptorupd
approved these changes
Feb 2, 2024
diptorupd
left a comment
diptorupd
left a comment
Contributor
There was a problem hiding this comment.
Great work! Yet another 3 year old feature request can be marked as complete 😄
ZzEeKkAa
force-pushed
the
feature/kernel_item
branch
2 times, most recently
from
February 2, 2024 19:27
87d4712 to
dac598d
Compare
ZzEeKkAa
force-pushed
the
feature/kernel_item
branch
from
February 2, 2024 20:08
dac598d to
b3ae9c2
Compare
ZzEeKkAa
enabled auto-merge
February 2, 2024 20:11
github-actions Bot
added a commit
that referenced
this pull request
Feb 2, 2024
Add kernel item and nd_item support f1e0eff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mocks for sycl's item and nd_item in python and add optional support for them as a first argument to experimental kernel. Changes does not introduce any changes to spriv kernel signature and works only at typing level.
So far there were provided two overloads:
Item.get_id(idx)NdItem.get_global_id(idx)Things that need to be done in following PRs:
get_local_id(idx)Grouptype and overloads related to itChecklist:
Fixes #274
Motivated by #1106