Repository navigation
Inconsistency in DatasetVersionInfo model? (Date vs string) #476
Description
I noticed that in the DatasetVersionInfo model, the timestamps use inconsistent types:
dataverse-client-javascript/src/datasets/domain/models/Dataset.ts
Lines 25 to 32 in 0043ddd
releaseTime and createTime are represented as Date objects, while lastUpdateTime is represented as an ISO 8601 string and not transformed into a Date object:
The return values from the Dataverse API for retrieving a dataset version are all consistently ISO 8601 strings:
I was wondering what the reason for this is, or whether this inconsistency should be cleaned up? (If so, I'd be open to opening a PR for that)
Activity
vera commentedon Aug 14, 2026
To add to this, I think there is a bug with the
releaseTime, it's being transformed to an "Invalid Date" object instead of undefined whenversionPayload.releaseTimewas undefined.ChengShi-1 commentedon Aug 20, 2026
I just verified that it is intentionally kept as a string. This was explicitly changed in commit 14d7990b (“fix: change lastUpdateTime type to string…”).
This is passed unchanged as
sourceLastUpdateTimefor optimistic-concurrency checks when updating dataset metadata. Converting it toDatecould alter its serialized actions. ADatehas millisecond precision and normalizes serialization, so it may lose fractional precision or alter the original ISO representation.Feel free to fix the bug from ReleaseTime if you want. Thanks!
vera commentedon Aug 24, 2026
Would it make sense to return
createTimeandreleaseTimeas strings too, for consistency?OK, I'll try to open a PR with a fix when I have the time.
ChengShi-1 commentedon Aug 24, 2026
I’d keep the current types and clarify the comment if needed.
createTimeandreleaseTimeare ordinary timestamps consumers may sort, compare, or format, soDateis the useful domain type.