Repository navigation
Remove Fingerprint Generation Capabilities - #7
Closed
decaffeinatedio wants to merge 2 commits into
Closed
decaffeinatedio wants to merge 2 commits into
decaffeinatedio wants to merge 2 commits into
Conversation
Collaborator
|
We will not take any action on this PR at this time. The project will be governed by the Trusted Server task force that is being constituted and it will make decisions on features and functions of the trusted server. The current code base is a proof of concept to demonstrate certain capabilities. |
|
Wasn't the request for us to specifically submit a PR with changes we'd recommend or like to see? |
Collaborator
|
Thanks. We deployed this as a templating option so the publisher can choose if they would like the 1st party synthetic ID. Closing this request out. |
11 of 14 tasks
vasujain00
pushed a commit
to vasujain00/trusted-server
that referenced
this pull request
Oct 25, 2026
…BTechLab#930) Addresses round-3 blockers IABTechLab#4, IABTechLab#5, IABTechLab#6 and splits IABTechLab#7. IABTechLab#4 placement: the merged design spec (IABTechLab#930, docs/superpowers/specs/ 2026-07-14-cache-header-audit-design.md §34) places this command at `ts origin audit-headers`, beside `ts origin probe-shareability`. Moved the module from commands/dev/audit/headers to commands/origin/audit_headers, removed the DevAuditCommand group, and added an AuditHeaders variant to OriginCommand. URLs now arrive through a repeatable --url (probe convention), not positional args. IABTechLab#5 exit codes: dropped the bespoke exit-code 3 and the process::exit call. The report now maps to RunOutcome (AssertionFailed on a FAIL, or a WARN under the new --strict flag; Success otherwise), returned through dispatch like every other command. main exits 2 for transport/config errors (Err), so a warn-only audit is never confused with one that could not run. Matches spec §59-69. IABTechLab#6 transport safety: explicit --url, the resolved origin root, and discovered assets all pass through the shared crate::url_guard::require_credential_safe_ transport used by probe-shareability -- HTTPS required except on loopback, no URL-embedded credentials. Discovery is additionally restricted to http/https assets, so file:/javascript:/data: links pulled from fetched HTML are dropped. IABTechLab#7 core-aware grading (Spec Task 1) is deliberately NOT in this change -- it spans trusted-server-core and is tracked as a follow-up (noted in the PR description). This command ships the generic ruleset. Docs: cli.md updated to the new command surface, --strict, and the 0/1/2 exit-code table. 776 CLI tests pass, clippy -D warnings clean, fmt + prettier clean.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the most problematic fingerprint generation from synthetic.rs while keeping the overall workflow intact (and tests still passing).
Even in a prototype, I would strongly recommend against creating a fingerprint like this.
Why?