Repository navigation
Add opt-in publisher-registered GPT initial delivery - #1460
Draft
ChristianPavilonis wants to merge 1 commit into
Draft
ChristianPavilonis wants to merge 1 commit into
ChristianPavilonis wants to merge 1 commit into
Conversation
| assert.deepEqual(JSON.parse(inlineJson(input)), input); | ||
| assert(!/[<>&\u2028\u2029]/u.test(inlineJson(input))); | ||
| const html = documentPage(input); | ||
| assert.equal((html.match(/<script>/g) ?? []).length, 1); |
| test("creative labels remain text instead of inserting inline markup", () => { | ||
| const html = creative('</div><script>throw new Error("injected")</script>&'); | ||
| assert(html.includes("</div><script>")); | ||
| assert.equal((html.match(/<script>/g) ?? []).length, 1); |
| bootstrapSha256: session.html | ||
| .map( | ||
| (html) => | ||
| [...html.matchAll(/<script[^>]*>([\s\S]*?)<\/script>/g)].find( |
| targetingKeys[record.elementId] = record.targetingKeys; | ||
| } | ||
| } | ||
| function registeredCandidateAllowed(ts, slotId, bid) { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialization = "publisher_registered". Absent/defaultautokeeps the existing wire format and automatic delivery.Related to #854. This is an opt-in correctness change, not a transparent fix for unmodified publishers or a claim of improved live CWV. It does not close the whole issue.
Validation
Exact fingerprints, commands, retained failures and limits are in
docs/superpowers/reviews/2026-10-27-854-publisher-registered-initial-delivery-validation.md.Before activation
Real GPT/GAM staging, publisher adoption, production activation and CWV validation remain unverified and require separate approval. Server/bootstrap/modules, publisher adapter and per-placement configuration must be released as a compatible set. Hosted GitHub CI is running; results are pending.