Repository navigation
Conversation
Build the harness CLI with the fixture feature used by its runtimes, and correct the Lockr troubleshooting field.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Known tables containing unknown fields will fail startup with the new binary. Run the new CLI's
ts config validate, correct the reported settings, push the cleaned config while the old binary runs, then deploy the new binary.Changes
crates/trusted-server-core/src/config.rscrates/trusted-server-core/src/settings.rscrates/trusted-server-core/src/integrations/adserver_mock.rscrates/trusted-server-core/src/integrations/didomi.rscrates/trusted-server-core/src/integrations/google_tag_manager.rscrates/trusted-server-core/src/integrations/gpt.rscrates/trusted-server-core/src/integrations/js_asset_proxy.rscrates/trusted-server-core/src/integrations/lockr.rscrates/trusted-server-core/src/integrations/nextjs/mod.rscrates/trusted-server-core/src/integrations/permutive.rscrates/trusted-server-core/src/integrations/sourcepoint.rscrates/trusted-server-core/src/integrations/testlight.rscrates/trusted-server-core/src/test_support/async_html_finalization.rscrates/trusted-server-integration-tests/tests/html_eof_runtime.rscrates/trusted-server-cli/tests/config_env_overlay.rsdocs/guide/configuration.mddocs/guide/integrations/lockr.mdapp_id.docs/guide/error-reference.mdCHANGELOG.mddocs/superpowers/specs/2026-10-27-strict-integration-validation-design.mddocs/superpowers/plans/2026-10-27-strict-integration-validation.mdCloses
Closes #1201
Spec
Not a feature (bug fix). The technical design is in
docs/superpowers/specs/2026-10-27-strict-integration-validation-design.md.Test plan
Run with Rust 1.98.1, Node 24.20.0 and Viceroy 0.21.0. Initial sandbox listener/keychain-access failures were resolved by full reruns with the required local access.
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest run— 1,211 tests passed, no type errorscd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo test-fastly-reuse,cargo test-cloudflare,cargo test-spin./scripts/async-html-finalization-local-test.sh axum --auction./scripts/async-html-finalization-local-test.sh fastly --release --auction— includes the test-utils release WASM buildfastly compute serve— not performedRegressions distinguish the original acceptance/diagnostic failures and cover all 15 production integration IDs, enabled/disabled fields, runtime warnings, open payload maps and deprecated compatibility fields.
The EOF harness builds its CLI with
trusted-server-core/test-utilsso validation recognizes the fixture integration selected by its runtimes. Ordinary production CLI builds retain the production ID list.Checklist
unwrap()in production codelogmacros (notprintln!)