Repository navigation
Conversation
Closed
4 tasks
Main renamed ts prebid bundle to ts prebid client, moved module selection to [integrations.prebid.bundle.modules], passes selections as --modules-json, and validates every module through metadata plus an injectable specifier resolver with a package-lock version check. Update the current-architecture section and the design to build on those seams: declare source on PrebidBundleSection, reuse resolveBundleModules for the fork, skip the lockfile check for forks, and keep manifest schemaVersion 1.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the design spec for teaching
ts prebid bundleto build the externalPrebid bundle from an operator's Prebid.js fork instead of the pinned npm
package. Spec only, no implementation.
The spec was drafted and revised in August 2026 on a branch based on the
retired rc/july line, so it was never pushed. This cherry-picks the four
spec commits onto
mainto preserve the work; the original branch carried390 unrelated commits.
Problem it describes
build-prebid-external.mjshardcodesnode_modules/prebid.jsas thepackage root, so an operator running a patched fork must build the fork,
pack a tarball, and edit a source-controlled
package.json. Nothing recordswhich fork commit produced a hosted bundle.
Still unaddressed on
main: no--prebid-sourceflag, nointegrations.prebid.bundle.sourcekey, andmanifest.jsoncarries nosourceprovenance.Proposal
#ref) or a local path, via config keyplus
--prebid-sourceoverride.SHA is unchanged; local paths validated, never mutated.
Review notes
Opened as a draft: the spec is a month old and predates changes to the
generator's specifier resolution (the LiveIntent shim alias and the
node_modules/prebid.js/dist/src/src/...rewrites). Section 5 should bere-derived against the current generator before anyone implements this.
Verification: docs Prettier gate passes; no code paths touched.