Skip to content

Proposal to standardize integrations - #113

Merged
aram356 merged 9 commits into
mainfrom
feature/standardize-integrations
Nov 21, 2025
Merged

aram356 merged 9 commits into
mainfrom
feature/standardize-integrations

Conversation

@aram356

@aram356 aram356 commented Nov 17, 2025 •

Copy link
Copy Markdown
Collaborator

Closes #109
Closes #110

@aram356
aram356 marked this pull request as draft November 17, 2025 22:45
@ChristianPavilonis

Copy link
Copy Markdown
Collaborator

I like it.

Take a look at #114 for the javascript. It bundles only the packages listed in an env var at build time into one javascript file, might be easier to integrate by loading all shims into one file and.
Also if there were a lot of integrations we could have potentially lot of js files to build into the binary.

On the rust side if a lot of proxies do the exact same thing we could create a derive macro or something.

@aram356 aram356 self-assigned this Nov 19, 2025
@aram356
aram356 requested review from ChristianPavilonis and jevansnyc and removed request for jevansnyc November 20, 2025 17:36
@aram356
aram356 marked this pull request as ready for review November 20, 2025 17:36

@ChristianPavilonis ChristianPavilonis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aram356
aram356 merged commit 360896e into main Nov 21, 2025
4 checks passed
@aram356
aram356 deleted the feature/standardize-integrations branch November 21, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants