Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-738 This preview will update automatically when you push new commits. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-738 This preview will update automatically when you push new commits. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⊙ Problem
HarperFast/harper#3320 (Backup CLI: refuse restore, delete and purge offline when a saved login targets a loopback address) changes how backup commands treat a target saved by
harper login. With a loopback target saved and the local server stopped,restore_backup,delete_backupandpurge_backupsnow fail instead of acting on local files. The backup pages did not mention saved or environment targets at all.❓ Your call: should these docs wait for the release?
I'd merge them with #3320. The page then describes the fixed behavior. Readers on older patch releases see a refusal their version does not have; an "As of vX.Y.Z" note can be added once the patch versions are known.
💡 Solution
harper logout <target>ortarget=<url>.✅ Verification
npm run buildpasses andprettier --checkis clean on both files.create_backup/list_backups/verify_backupand theharper logoutroute were run through the built CLI in a temporary install. The.envandget_backupstatements are from readingbin/login.tsandbin/backup.ts, not from a run.🤖 Generated by Claude Code (Claude Opus 5.5); posted via @cb1kenobi.
Related PRs: none found
Complexity: easy
Review-Coverage: authored=claude; ran=gemini,cursor-composer,codex; adjudicated=domain; declined=cursor-grok,cursor-kimi,cursor-muse; rounds=2; full=1 @ a8cb276
Review-Attention: skim ~2m (decisions: loopback-liveness-proxy, env-target-as-explicit, overview-crosslink-vs-mirror) @ a8cb276