Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

Desktop Mode: Improvements for M1 and Trackpad iPads - #1142

Merged
ccrama merged 26 commits into
core_data_rewritefrom
desktop_mode
Jan 10, 2021
Merged

ccrama merged 26 commits into
core_data_rewritefrom
desktop_mode

Conversation

@ccrama

@ccrama ccrama commented Dec 14, 2020 •

Copy link
Copy Markdown
Collaborator
  • Context menu interaction for links and comments
  • New "Desktop Mode" setting for sticky navigation sidebar
  • Bug fixes from initial v7 TestFlight, v7 Testflight build number

@ccrama
ccrama marked this pull request as draft December 14, 2020 03:03
@ccrama
ccrama changed the base branch from develop to core_data_rewrite December 14, 2020 05:38
@ccrama
ccrama marked this pull request as ready for review December 19, 2020 00:48
return OnboardingFeaturePageViewController(text: text, subText: subText, image: image)
case .splash(let text, let subText, let image):
return OnboardingSplashPageViewController(text: text, subText: subText, image: image)
case .testflight(_):

@SlideCI SlideCI Dec 23, 2020 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Arguments can be omitted when matching enums with associated values if they are not used.
empty_enum_arguments OnboardingPageViewController.swift:32

@ccrama
ccrama merged commit 9808eaa into core_data_rewrite Jan 10, 2021
@ccrama
ccrama deleted the desktop_mode branch January 10, 2021 02:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants