iot.api-client.mqtt_example.cloudiot_mqtt_example_test: test_gateway_send_data_for_device failed #2861

Activity

1. flaky-bot

   added

   buildcop:issue

   priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   on Feb 11, 2020
2. blunderbuss-gcf

   assigned

   kurtisvg

   on Feb 11, 2020
3. kurtisvg

   assigned

   gguuss

   and unassigned

   kurtisvg

   on Feb 11, 2020
4. flaky-bot commented on Feb 12, 2020

   

   flaky-botBot

   on Feb 12, 2020

   Author

   More actions

   Test passed in build fbcdef1 (https://source.cloud.google.com/results/invocations/04397697-dd91-4cfb-a092-94cdeb1e87b2)! Closing this issue.
5. flaky-bot

   closed this as completedon Feb 12, 2020
6. tbpg

   added

   buildcop: issue

   and removed

   buildcop:issue

   on Feb 16, 2020
7. flaky-bot

   reopened this on Feb 26, 2020
8. flaky-bot

   added

   buildcop: flaky

   on Feb 26, 2020
9. flaky-bot commented on Feb 26, 2020

   

   flaky-botBot

   on Feb 26, 2020

   Author

   More actions

   Looks like this issue is flaky. 😟

   I'm going to leave this open and stop commenting.

   A human should fix and close this.

   iot.api-client.mqtt_example.cloudiot_mqtt_example_test: test_gateway_send_data_for_device failed
   buildID: ff9682e
   buildURL: Build Status, Sponge
   status: failed
10. yoshi-automation

    added

    🚨This issue needs some love.This issue needs some love.

    on Feb 26, 2020
11. leahecole

    removed

    🚨This issue needs some love.This issue needs some love.

    on Feb 26, 2020
12. 19 remaining items

    Load more

13. gguuss commented on Apr 15, 2020

    

    gguuss

    on Apr 15, 2020

    Contributor

    More actions

    I believe that the samples already are correctly ordering the creations and deletions. That said, the race condition, multi-threading, and being unable to delete non-empty resources are the source of pain here.
14. tmatsuo commented on Apr 15, 2020

    

    tmatsuo

    on Apr 15, 2020

    Contributor

    More actions

    Yeah, if we just put 8 rpcs serially as we do in test_gateway_listen_for_bound_device_configs the success rate will be a product of those 8 rpcs (create/delete for 4 resources).

    For example, if the success rate of those rpcs are 0.9, the whole success rate will be 0.9^8 = 0.43046721. If we retry this test 5 times, the success rate will be 1 - (0.56953279^5) = 0.94007698385.

    Instead, we should have 4 fixtures with retrying each creation/deletion. If we retry 5 times for example, the success rate for each rpcs with the retries will be 1 - 0.1^5 = 0.99999, so the whole success rate will be 0.99999^8 = 0.9999200028. Without retrying the test itself, it is already more robust than the above example :)

    🚀React with 🚀1Reacted by Gus Class
15. tmatsuo

    closed this as completedin #3428on Apr 21, 2020
16. tmatsuo

    added a commit that references this issue on Apr 21, 2020

    [iot] fix: use fixtures for resource setup/teardown (#3428)

    ...

    This issue will close once commit e2cf90d is merged into the 'main' branch.

    e2cf90d
17. flaky-bot

    reopened this on Apr 27, 2020
18. flaky-bot commented on Apr 27, 2020

    

    flaky-botBot

    on Apr 27, 2020

    Author

    More actions

    Oops! Looks like this issue is still flaky. 😬

    I reopened the issue, but a human will need to close it again.

    ---

    commit: 2b74710
    buildURL: Build Status, Sponge
    status: failed
19. gguuss

    added

    priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

    and removed

    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.

    on Apr 27, 2020
20. yoshi-automation

    removed

    🚨This issue needs some love.This issue needs some love.

    on Apr 27, 2020
21. gguuss commented on Apr 27, 2020

    

    gguuss

    on Apr 27, 2020

    Contributor

    More actions

    I'm considering disabling the tests that are multithreaded as they seem to be causing issues with buildcop.
22. tmatsuo commented on May 5, 2020

    

    tmatsuo

    on May 5, 2020

    Contributor

    More actions

    I think we haven't seen this failure for a while.
    Maybe we can close this, and see how flaky it is now.
23. tmatsuo

    closed this as completedon May 5, 2020
24. GoogleCloudPlatform

    locked as resolved and limited conversation to collaborators on May 5, 2020