Skip to content

Updating tedious in mssql docs sample #154

Open

Description

@ruyadorno

In order to get the current mssql-based SQL Server sample working on https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/main/cloud-sql/sqlserver/mssql we'll need to make sure mssql is using a newer version of tedious, which supports the connector config property which in turn enable support to the Cloud SQL Node.js Connector.

Once mssql is updated upstream we should be able to update our SQL Server doc sample to start using the Node.js Connector package.

Related to: #140

Activity

  1. ruyadorno commented on Jul 10, 2023

    @ruyadorno
    ContributorAuthor

    Update: Opened a PR in mssql to try and start that conversation with their maintainers, there are a few issues at play though, like the fact that the new version of tedious dropped support to node14 which in turn will require a semver-major bump in mssql next release (once that update lands).

    Ref: tediousjs/node-mssql#1500

  2. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: cleanupAn internal cleanup or hygiene concern.
    on Jul 10, 2023
  3. edosrecki commented on Sep 6, 2023

    @edosrecki
    Contributor
  4. jackwotherspoon commented on Dec 16, 2024

    @jackwotherspoon
    Collaborator

    Docs samples are now using "mssql": "^11.0.0" (refs)

    Should be unblocked to add a connect-connector.js and connect-connector-with-iam-authn.js to nodejs-docs-samples/cloud-sql/sqlserver folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: cleanupAn internal cleanup or hygiene concern.type: docsImprovement to the documentation for an API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions