Repository navigation
Tedious sample config contains extraneous properties #132
Description
Bug Description
In the current README sample and in tedious related system tests there are two properties: server and port that should not be necessary.
Example code (or command)
These properties should not be required:
const clientOpts = await connector.getTediousOptions({
instanceConnectionName: process.env.SQLSERVER_CONNECTION_NAME,
ipType: 'PUBLIC'
});
const connection = new Connection({
- server: '0.0.0.0',
authentication: {
type: 'default',
options: {
userName: process.env.SQLSERVER_USER,
password: process.env.SQLSERVER_PASS,
},
},
options: {
...clientOpts,
- port: 9999,
database: process.env.SQLSERVER_DB,
},
})More Info
Currently this properties are required due to a bug in the tedious driver itself that still tries to validate these properties even when the user is defining a custom connector factory method.
Related bug in Tedious: tediousjs/tedious#1541
Activity
ruyadorno commentedon May 30, 2023
Related PR to fix the issue in
tedious: tediousjs/tedious#1542