Move serializers to a separate project and NuGet to support System.Text.Json in another project and NuGet #148

Activity

1. matt-lethargic commented on Aug 12, 2020

   

   matt-lethargic

   on Aug 12, 2020

   Member

   More actions

   @xfischer I've been looking at the issues that System.Text.Json has brought about and thinking that this could be a solution in a v2 of GeoJSON.Net.

   • Natively support System.Text.Json
   • Contrib lib for Json.Net

   Thoughts?

   👍React with 👍2Reacted by Andrii Chebukin and Ben Roth
2. xfischer commented on Aug 12, 2020

   

   xfischer

   on Aug 12, 2020

   Member

   More actions

   Yes I agree to set System.Text.Json as the default (de)serializer, and provide backwards compatibility as a separate NuGet package, as suggested by @xperiandri.
   Let's create a branch for that purpose and get started. @matt-lethargic did you look how to migrate existing converters ? As I saw quickly it seems like a lot of work to support System.Text.Json, but hopefully we are covered with unit tests.

   I'll take care of the Contribs in a similar new-branch approach.

   Related MS docs :

   • https://docs.microsoft.com/dotnet/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to
   • https://docs.microsoft.com/dotnet/standard/serialization/system-text-json-converters-how-to
3. matt-lethargic commented on Aug 12, 2020

   

   matt-lethargic

   on Aug 12, 2020

   Member

   More actions

   I haven't looked at the migration properly yet, but have docs in front of me.
   Will start a v2 branch
4. steveoh commented on Sep 2, 2020

   

   steveoh

   on Sep 2, 2020

   More actions

   I've been migrating a similar project to STJ and it's not that bad. I was going to fork this for my project but I am glad that it is on your radar and I am happy to contribute. How's the progress so far?
5. steveoh commented on Sep 3, 2020

   

   steveoh

   on Sep 3, 2020

   Last edited by steveoh

   More actions

   Since there wasn't any visible progress, I went ahead and forked. Please provide some early feedback and participate!