[KingDarBoja]

Tooling Improvements

ESLint Changes

• Migrated to ESLint 10 Flat Config.
• Dropped the old "eslint-config-google" package.
• Updated typescript-eslint to v8
• Migrate both require-jsdoc and valid-jsdoc rules by adding the eslint-plugin-jsdoc plugin per https://eslint.org/docs/latest/rules/valid-jsdoc#rule-details

Rollup

• Upgrade to Rollup 4 with compatible CommonJS, node-resolve, and TypeScript plugins
• Upgrade glob to v13 for Node.js 20 support and use its globSync API

This is the second stage of #123 pull request but solely focused on ESLint and Rollup tools.

[KingDarBoja]

@armando-navarro bump

[armando-navarro]

Hi @KingDarBoja, thanks for splitting this out of #123, and sorry for the long wait. I built the branch and compared its output with main's. Three things before I approve, then a few small ones.

Required: CommonJS output options in rollup.config.js

Rollup 4 changed some CommonJS defaults, which changes the published .cjs.js bundles:

• performance now keeps a native import('firebase/performance'), so Jest users get "A dynamic import callback was invoked without --experimental-vm-modules".
• Every sub-package bundle loses the __esModule marker, so jest.spyOn on a namespace import no longer replaces the real function.

These three options bring the bundles back to today's output, apart from comments:

{
  file: resolve(component, main),
  format: 'cjs',
  dynamicImportInCjs: false,
  esModule: true,
  interop: 'auto',
  sourcemap: true
},

Required: leftovers from the removed lint directives

The deleted eslint-disable comments left whitespace-only lines behind (git diff 2f2bb97 --check lists them), and the comments explaining them, such as "auth is used as a namespace to access types", now explain nothing. Please delete both.

Required: the jsdoc rules

The old config had these rules switched off. Turning them on adds 177 warnings to every lint run, and yarn lint:fix fills 16 files with empty @param stubs. I'd drop the jsdoc block and eslint-plugin-jsdoc from this PR and leave JSDoc for a separate change.

Optional

• ecmaVersion and sourceType under parserOptions are ignored in flat config. Move them up to languageOptions or delete them.
• Renaming rollup.config.js to rollup.config.mjs removes the warning Node prints on every build.
• eslint.config.mjs needs a final newline, and @eslint/js and typescript-eslint are out of alphabetical order in devDependencies.

If I've misread anything about the Rollup options, let me know.

[armando-navarro]

Thanks @KingDarBoja for the commits addressing my review. Everything looks good now. Approving.