[Navigation] iOS - Blank page appears when moving from distance rates settings to More features page by WojtekBoman · Pull Request #56870 · Expensify/App

WojtekBoman · 2025-02-14T11:03:51Z

Explanation of Change

This PR fixes navigating after dismissing modal in src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx.

After fixing:

Screen.Recording.2025-02-17.at.13.11.39.mov

Fixed Issues

$ #56809
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Precondition:

Distance rates feature is enabled.
Taxes are not enabled.

Launch ND or hybrid app.
Go to workspace settings > Distance rates.
Tap Settings.
Tap More features.
Verify if a blank page has not been shown during navigating

Offline tests

QA Steps

Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…ettings to More features page

melvin-bot · 2025-02-14T12:00:33Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2025-02-16T13:10:36Z

                                                    Navigation.dismissModal();
-                                                    Navigation.isNavigationReady().then(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));
+                                                    navigateAfterInteraction(() => Navigation.goBack(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID)));


I think we could just directly navigate to ROUTES.WORKSPACE_MORE_FEATURES. like in other places.

App/src/pages/workspace/tags/TagSettingsPage.tsx

Line 200 in d68deae

onPress={() => Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID))}

Not sure why Navigation.dismissModal(); was added, tried to track it but couldn't find a reason. Seems to work perfectly fine without a delay.

I also cannot think of a reason why we should simiss and navigate, so maybe we could just do that @WojtekBoman what do you think?

What should happen after navigating back from the More features page? Should we open RHP containing the link that we used? If so, using navigate will be a good solution. If we don't want to go back to the RHP, we need to dismiss it first. I'm attaching a video showing how it works in TagSettings

Screen.Recording.2025-02-17.at.09.07.34.mov

Btw, my solution must be adjusted, I checked it on web and it doesn't work correctly. Once you reply, I'll adjust the PR

I think how it looks in the video is correct

Ok, I'll adjust it in a moment :)

I fixed that, but I noticed one thing. On mobile platforms when going back we need to go through the sidebar page. It's expected behaviour because we pushed a new split navigator. However, I see that maybe we should adjust this behavior to be able to push the split navigator without a sidebar page as it would be useful to fix other issues like:

[Due for payment 2025-03-21] [Due for payment 2025-03-03] iOS- Reports- App returns to Inbox instead of expense report after editing expense from Report #56801

[HOLD for payment 2025-04-14] [Navigation][HIGH] Chat - User lands on inbox before being redirected to new created chat or group. #56799

But, I wouldn't hold this issue until we fix that. Could you merge this one and create a new issue for me with adjustments to the split behavior where I can fix all these issues globally?

Here's a video showing how it behaves on native platforms

Screen.Recording.2025-02-17.at.09.56.03.mov

Sounds good, can you please fix the ESLint in this file, we not cping and its a small change

…page

getusha · 2025-02-17T20:58:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-18.at.4.20.42.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2025-02-17.at.11.42.17.at.night.mov

iOS: Native

Screen.Recording.2025-02-17.at.11.58.05.at.night.mov

iOS: mWeb Safari

Screen.Recording.2025-02-17.at.11.46.30.at.night.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-17.at.11.36.54.at.night.mov

MacOS: Desktop

Screen.Recording.2025-02-17.at.11.49.48.at.night.mov

mountiny

Thanks!

OSBotify · 2025-02-18T13:44:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-19T03:41:46Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-20T02:49:23Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.1-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Fix issue: iOS - Blank page appears when moving from distance rates s…

e77449a

…ettings to More features page

WojtekBoman marked this pull request as ready for review February 14, 2025 12:00

WojtekBoman requested a review from a team as a code owner February 14, 2025 12:00

melvin-bot Bot requested review from getusha and removed request for a team February 14, 2025 12:00

WojtekBoman mentioned this pull request Feb 14, 2025

[$250] [Due for payment 2025-02-27] [Navigation] iOS - Blank page appears when moving from distance rates settings to More features page #56809

Closed

2 of 8 tasks

getusha reviewed Feb 16, 2025

View reviewed changes

mountiny assigned WojtekBoman Feb 17, 2025

WojtekBoman added 4 commits February 17, 2025 09:59

Fix navigating from PolicyDistanceRatesSettingsPage to More Features …

82967ba

…page

Fix named imports in PolicyDistanceRatesSettingsPage

8df3228

Remove customUnitID from PolicyDistanceRatesSettingsPage

d6e7bac

Add early return to clearErrorFields in PolicyDistanceRatesSettingsPage

26e09bb

getusha approved these changes Feb 18, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny February 18, 2025 13:21

mountiny approved these changes Feb 18, 2025

View reviewed changes

mountiny merged commit 18c43dd into Expensify:main Feb 18, 2025

github-actions Bot mentioned this pull request Feb 19, 2025

Deploy Checklist: New Expensify 2025-02-19 #57066

Closed

56 tasks done

mitarachim mentioned this pull request Feb 19, 2025

[HOLD #56812][Back nav] iOS - Distance rates - Bottom tab appears on Settings when swiping from workspace settings #57075

Closed

2 of 8 tasks

Conversation

WojtekBoman commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

getusha commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 18, 2025

Uh oh!

github-actions Bot commented Feb 19, 2025

Uh oh!

github-actions Bot commented Feb 20, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

WojtekBoman commented Feb 14, 2025 •

edited

Loading

getusha commented Feb 17, 2025 •

edited

Loading