add new missing detail contact modal by DylanDylann · Pull Request #55484 · Expensify/App

DylanDylann · 2025-01-20T17:08:51Z

Explanation of Change

Fixed Issues

$ #54041
PROPOSAL: #54041 (comment)

Tests

Precondition:

User is assigned a physical Expensify Card.
Personal details are not filled yet.

Go to workspace chat.
Click Add shipping details.
Enter all info and proceed to confirmation page.
Click Confirm.
Enter incorrect magic code.
An error will be displayed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition:

User is assigned a physical Expensify Card.
Personal details are not filled yet.

Go to workspace chat.
Click Add shipping details.
Enter all info and proceed to confirmation page.
Click Confirm.
Enter incorrect magic code.
An error will be displayed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-05.at.16.38.06.mov

Android: mWeb Chrome

Screen.Recording.2025-02-05.at.16.12.56.mov

iOS: Native

Screen.Recording.2025-02-05.at.16.36.32.mov

iOS: mWeb Safari

Screen.Recording.2025-02-05.at.16.11.02.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-05.at.16.03.39.mov

MacOS: Desktop

Screen.Recording.2025-02-05.at.16.13.47.mov

melvin-bot · 2025-02-05T08:01:30Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-02-05T08:37:43Z

Uploading videos...

DylanDylann · 2025-02-05T09:14:50Z

There are some mistakes in #54614. We decided to use MissingPersonalDetails folded so this PR should be unhold

DylanDylann · 2025-02-05T09:17:01Z

@allgandalf All yours

DylanDylann · 2025-02-06T08:31:38Z

@allgandalf Please review this one

allgandalf

little confused with the changes, it would be great if you can explain me a bit

DylanDylann · 2025-02-07T03:40:41Z

@allgandalf Back to you

allgandalf · 2025-02-10T06:30:41Z

left comments again

allgandalf · 2025-02-11T05:48:34Z

Also conflicts

DylanDylann · 2025-02-11T05:55:30Z

Also conflicts

@allgandalf Do you have any other concerns?

allgandalf · 2025-02-11T05:56:42Z

I was saying that this branch has conflicts 😅

DylanDylann · 2025-02-11T06:01:19Z

I am on another task, please continue your reviewing. I will resolve the conflict later. I hope it doesn't block your reviewing

DylanDylann · 2025-02-11T08:46:28Z

@allgandalf Kindly bump

allgandalf · 2025-02-11T08:47:34Z

out for sometime, i will review this later today @DylanDylann

allgandalf · 2025-02-12T07:51:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-18.at.5.32.23.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-02-18.at.5.30.34.PM.mov

iOS: Native

Screen.Recording.2025-02-18.at.5.54.26.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-02-18.at.5.55.55.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-18.at.5.22.45.PM.mov

MacOS: Desktop

Screen.Recording.2025-02-18.at.5.28.40.PM.mov

allgandalf · 2025-02-12T08:14:40Z

@DylanDylann the RHP disappears for me when i enter magic code, can you please check:

Screen.Recording.2025-02-12.at.1.43.19.PM.mov

DylanDylann · 2025-02-13T06:58:01Z

@allgandalf Updated

DylanDylann · 2025-02-14T09:25:06Z

@allgandalf Friendly bump

mountiny · 2025-02-17T08:50:33Z

@allgandalf wht is your eta for this one?

allgandalf · 2025-02-17T15:21:40Z

I'll try to finish this one today, else tomorrow early morning for sure!

allgandalf · 2025-02-18T11:56:00Z

+    const handleSubmitForm = useCallback(
        (validateCode: string) => {
            updatePersonalDetailsAndShipExpensifyCards(values, validateCode);
-            clearDraftValues(ONYXKEYS.FORMS.PERSONAL_DETAILS_FORM);


@DylanDylann do you suggest that we remove clearning the values here because we already do it in the modal?

https://github.com/Expensify/App/pull/55484/files#diff-b17d5f8db06f1ef077ff03482df8a76eb52e1a2deb45bb8aa7b721047a0b2ec0R41

allgandalf

This is ready to get merged!

Also verified that entering the correct code doesn't show any error 😆

Screen.Recording.2025-02-18.at.5.56.11.PM.mov

mountiny · 2025-02-18T14:06:33Z

+    handleSubmitForm: (validateCode: string) => void;
+    isValidateCodeActionModalVisible: boolean;
+    onClose?: () => void;


all of these should have docs

mountiny · 2025-02-18T14:07:09Z

+    const missingDetails =
+        !privatePersonalDetails?.legalFirstName ||
+        !privatePersonalDetails?.legalLastName ||
+        !privatePersonalDetails?.dob ||
+        !privatePersonalDetails?.phoneNumber ||
+        isEmptyObject(privatePersonalDetails?.addresses) ||
+        privatePersonalDetails.addresses.length === 0;


Isnt there a helper method for this? i think we should abstract it to one util methodas its reused

mountiny

Overall the changes look good to me and we can address my comments in a follow up, this bug is causing confusion to users so we should get this merged asap

trjExpensify · 2025-02-18T14:29:17Z

Hiya! To echo what Vit said, we were close to losing a new customer over this yesterday, as they seemingly completed what was asked of them in the modal but it failed because of an incorrect magic code entered. It's important we keep on top of making swift progress through these key enablement flows, as they ultimately result in losing out on potential revenue. Thanks!

allgandalf · 2025-02-18T14:34:42Z

Apologies @trjExpensify @mountiny , I didn't expect to get this one delayed for so long, no excuses for the delay, would be more swift moving forward 😞

MarioExpensify

Yep, code looks good, let's move forward!

OSBotify · 2025-02-18T15:04:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-19T03:40:55Z

🚀 Deployed to staging by https://github.com/MarioExpensify in version: 9.1.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-20T02:48:32Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.1-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

DylanDylann added 3 commits January 16, 2025 16:57

add new missing detail contact modal

04b2c03

merge main

fd4cf86

complete the implementation

8b52bd7

DylanDylann marked this pull request as ready for review February 5, 2025 08:01

DylanDylann requested a review from a team as a code owner February 5, 2025 08:01

melvin-bot Bot requested review from allgandalf and removed request for a team February 5, 2025 08:01

merge main

5b182c5

DylanDylann force-pushed the Dylan/fix54041 branch from 4e15978 to 5b182c5 Compare February 5, 2025 08:10

DylanDylann marked this pull request as draft February 5, 2025 08:16

fix lint

7f0d266

DylanDylann marked this pull request as ready for review February 5, 2025 08:37

fix error resend code

60d8cdf

allgandalf reviewed Feb 6, 2025

View reviewed changes

Comment thread src/libs/actions/PersonalDetails.ts Resolved

Comment thread src/libs/actions/PersonalDetails.ts Resolved

Comment thread src/types/onyx/PrivatePersonalDetails.ts Resolved

mountiny assigned DylanDylann Feb 6, 2025

add loading spinner

8da87f2

DylanDylann added 2 commits February 11, 2025 14:11

merge main

1ad2394

merge main

41d564f

remove goback

4e4bc29

allgandalf reviewed Feb 18, 2025

View reviewed changes

allgandalf approved these changes Feb 18, 2025

View reviewed changes

melvin-bot Bot requested a review from MarioExpensify February 18, 2025 12:27

mountiny reviewed Feb 18, 2025

View reviewed changes

mountiny approved these changes Feb 18, 2025

View reviewed changes

MarioExpensify approved these changes Feb 18, 2025

View reviewed changes

MarioExpensify merged commit 2b5ca51 into Expensify:main Feb 18, 2025

github-actions Bot mentioned this pull request Feb 19, 2025

Deploy Checklist: New Expensify 2025-02-19 #57066

Closed

56 tasks done

melvin-bot Bot mentioned this pull request Feb 20, 2025

[Due for payment 2025-02-27] [$250] Expensify Card - Incorrect magic code is accepted during add shipping details flow #54041

Closed

6 of 8 tasks

Conversation

DylanDylann commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 5, 2025

Uh oh!

DylanDylann commented Feb 5, 2025

Uh oh!

DylanDylann commented Feb 5, 2025

Uh oh!

DylanDylann commented Feb 5, 2025

Uh oh!

DylanDylann commented Feb 6, 2025

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Feb 7, 2025

Uh oh!

allgandalf commented Feb 10, 2025

Uh oh!

allgandalf commented Feb 11, 2025

Uh oh!

DylanDylann commented Feb 11, 2025

Uh oh!

allgandalf commented Feb 11, 2025

Uh oh!

DylanDylann commented Feb 11, 2025

Uh oh!

DylanDylann commented Feb 11, 2025

Uh oh!

allgandalf commented Feb 11, 2025

Uh oh!

allgandalf commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Feb 12, 2025

Uh oh!

DylanDylann commented Feb 13, 2025

Uh oh!

DylanDylann commented Feb 14, 2025

Uh oh!

mountiny commented Feb 17, 2025

Uh oh!

allgandalf commented Feb 17, 2025

Uh oh!

allgandalf Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Feb 18, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Feb 18, 2025

Uh oh!

allgandalf commented Feb 18, 2025

Uh oh!

DylanDylann commented Jan 20, 2025 •

edited

Loading

allgandalf commented Feb 12, 2025 •

edited

Loading