[tgolen]

• Injects the dev report IDs in a different manner
• Corrects the name of the collectionID param
• Uses the recommended method for the display name of an HOC
• Fixes a reference for state that was a little wonky

It's best to review with whitespace changes turned off: https://github.com/AndrewGable/ReactNativeChat/pull/133/files?diff=unified&w=1

[Jag96]

I'm seeing the following error when running npm run web on this branch (master works fine)

SyntaxError: Unexpected token 'export'
    at wrapSafe (internal/modules/cjs/loader.js:1116:16)
    at Module._compile (internal/modules/cjs/loader.js:1164:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)
    at Object.<anonymous> (/Users/joegambino/Expensidev/ReactNativeChat/webpack.dev.js:4:19)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ReactNativeChat@1.0.1-1 web: `webpack-dev-server --open --config webpack.dev.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ReactNativeChat@1.0.1-1 web script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/joegambino/.npm/_logs/2020-08-13T16_45_34_913Z-debug.log

which points to const devConfig = require('./src/CONFIG.DEV'); in webpack.dev.js.

Are you seeing this locally? Just confirming this isn't an issue on my end.

[tgolen]

Hmm, let me try

[tgolen]

Oh, I know why. Change your config file to look like this (using module.exports)

module.exports = {
    // Add a comma separated list of report IDs here to load into the LHN
    REPORT_IDS: '35,29,123123123',
};

I'll update the example file

[Jag96]

This is working fine for me on web, however, on iOS I see this error on startup (On master this gets through to the allSettled before throwing an error). Can you confirm?

[Jag96]

I don't see this referenced anywhere, is there another place this can be used that isn't obvious? Same for REPORTS

[tgolen]

These are cleaned up in my active branch, so you can ignore this for now.

[tgolen]

Yeah, Andrew reported that crash as well and we are discussing it over here: #127

[AndrewGable]

Closes #126

[Jag96]

LGTM 👍

[github-actions]

🚀 Deployed to staging by https://github.com/Jag96 in version: 9.1.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.1-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌