[Due for payment 2025-06-09] [$250] Expense - Text selection mode is triggered when long tapping on expense in the expense report

@JmillsExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+300402kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Money Requests

Action Performed:

Precondition:

Log in with Expensifail account.

Go to staging.new.expensify.com on mweb Chrome or mweb iOS Safari.
Go to workspace chat.
Submit two expenses to the workspace chat.
Tap on the expense preview.
Long tap on any expense.

Expected Result:

Text selection mode will not be triggered when long tapping on expense in the expense report.

Actual Result:

Text selection mode is triggered when long tapping on expense in the expense report.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021922416876473367326
Upwork Job ID: 1922416876473367326
Last Price Increase: 2025-05-13
Automatic offers:

Krishna2323 | Contributor | 107318849

Issue Owner

Current Issue Owner: @JmillsExpensify

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Text selection mode is triggered when long tapping on expense in the expense report

What is the root cause of that problem?

The parent container of TransactionItemRow does not have styles.userSelectNone style applied to it and dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true is also missing.

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 216 to 260 in 0601503

    
           <PressableWithFeedback 
        
               key={transaction.transactionID} 
        
               onPress={(e) => { 
        
                   if (isMouseDownOnInput) { 
        
                       e?.stopPropagation(); 
        
                       return; 
        
                   } 
        
                   if (selectionMode?.isEnabled) { 
        
                       toggleTransaction(transaction.transactionID); 
        
                       return; 
        
                   } 
        
                   navigateToTransaction(transaction); 
        
               }} 
        
               accessibilityLabel={translate('iou.viewDetails')} 
        
               role={getButtonRole(true)} 
        
               isNested 
        
               hoverDimmingValue={1} 
        
               onMouseDown={(e) => e.preventDefault()} 
        
               id={transaction.transactionID} 
        
               style={[pressableStyle]} 
        
               onMouseLeave={handleMouseLeave} 
        
               onLongPress={() => { 
        
                   if (!displayNarrowVersion) { 
        
                       return; 
        
                   } 
        
                   if (selectionMode?.isEnabled) { 
        
                       toggleTransaction(transaction.transactionID); 
        
                       return; 
        
                   } 
        
                   setSelectedTransactionID(transaction.transactionID); 
        
                   setIsModalVisible(true); 
        
               }} 
        
           > 
        
               <TransactionItemRow 
        
                   transactionItem={transaction} 
        
                   isSelected={isTransactionSelected(transaction.transactionID)} 
        
                   shouldShowTooltip 
        
                   dateColumnSize={dateColumnSize} 
        
                   shouldUseNarrowLayout={displayNarrowVersion} 
        
                   shouldShowChatBubbleComponent 
        
                   onCheckboxPress={toggleTransaction} 
        
               /> 
        
           </PressableWithFeedback>

What changes do you think we should make in order to solve the problem?

Add styles.userSelectNone style and dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true to PressableWithFeedback.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A - UI Issue

What alternative solutions did you explore? (Optional)

N/A

Result

@JmillsExpensify

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

Job added to Upwork: https://www.upwork.com/jobs/~021922416876473367326

@ahmedGaber93

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

@ahmedGaber93

@ahmedGaber93 @JmillsExpensify @ahmedGaber93 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: edge case

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/55157/files#r2134838385
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

This is a straight forward fix, no regression test required.

@Krishna2323

Payment summary:

$250 to @Krishna2323 via Upwork
$250 to @ahmedGaber93 via NewDot

@JmillsExpensify

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

Contributor paid, so closing this out.

Confirming this payment summary is correct: #61442 (comment)

@ahmedGaber93

$250 approved for @ahmedGaber93

Navigation Menu

Repository navigation

[Due for payment 2025-06-09] [$250] Expense - Text selection mode is triggered when long tapping on expense in the expense report #61442

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Result

19 remaining items

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<PressableWithFeedback
	key={transaction.transactionID}
	onPress={(e) => {
	if (isMouseDownOnInput) {
	e?.stopPropagation();
	return;
	}

	if (selectionMode?.isEnabled) {
	toggleTransaction(transaction.transactionID);
	return;
	}

	navigateToTransaction(transaction);
	}}
	accessibilityLabel={translate('iou.viewDetails')}
	role={getButtonRole(true)}
	isNested
	hoverDimmingValue={1}
	onMouseDown={(e) => e.preventDefault()}
	id={transaction.transactionID}
	style={[pressableStyle]}
	onMouseLeave={handleMouseLeave}
	onLongPress={() => {
	if (!displayNarrowVersion) {
	return;
	}
	if (selectionMode?.isEnabled) {
	toggleTransaction(transaction.transactionID);
	return;
	}
	setSelectedTransactionID(transaction.transactionID);
	setIsModalVisible(true);
	}}
	>
	<TransactionItemRow
	transactionItem={transaction}
	isSelected={isTransactionSelected(transaction.transactionID)}
	shouldShowTooltip
	dateColumnSize={dateColumnSize}
	shouldUseNarrowLayout={displayNarrowVersion}
	shouldShowChatBubbleComponent
	onCheckboxPress={toggleTransaction}
	/>
	</PressableWithFeedback>

[Due for payment 2025-06-09] [$250] Expense - Text selection mode is triggered when long tapping on expense in the expense report #61442

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 6, 2025

Krishna2323 commented on May 6, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Result

melvin-bot commented on May 9, 2025

melvin-bot commented on May 13, 2025

melvin-bot commented on May 13, 2025

melvin-bot commented on May 13, 2025

19 remaining items

melvin-bot commented on Jun 2, 2025

ahmedGaber93 commented on Jun 8, 2025

BugZero Checklist:

JmillsExpensify commented on Jun 11, 2025

melvin-bot commented on Jun 16, 2025

JmillsExpensify commented on Jun 18, 2025

trjExpensify commented on Jul 11, 2025

JmillsExpensify commented on Jul 11, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions