Repository navigation
[Due for payment 2025-05-20] [$250] Desktop - "Select" modal is shown with a blank background #61003
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.1.33-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #60829
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other
Action Performed:
Precondition: Use a small desktop window
- Launch Expensify desktop app.
2.Go to existing Workspace or create new - Go to Members (as an admin)
- Add a few members if you are alone
- Long press on some item
Expected Result:
"Select" modal is shown with the background on the page
Actual Result:
"Select" modal is shown with empty background
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6815785_1745883956643.Screen_Recording_2025-04-29_at_2.34.00_at_night.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021917138785738997830
- Upwork Job ID: 1917138785738997830
- Last Price Increase: 2025-04-29
- Automatic offers:
- ikevin127 | Reviewer | 107192611
- linhvovan29546 | Contributor | 107192613
Activity
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 29, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Apr 29, 2025
💬 A slack conversation has been started in #expensify-open-source
thelullabyy commentedon Apr 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Select" modal is shown with empty background
What is the root cause of that problem?
We're using
BottomDockedModaland set opacity ofbackdropStyleis{}for non-web cases.App/src/components/Modal/BottomDockedModal/index.tsx
Line 135 in 1d48288
What changes do you think we should make in order to solve the problem?
Add condition to apply
backdropOpacityto Desktop.getPlatform() === CONST.PLATFORM.WEB || getPlatform() === CONST.PLATFORM.DESKTOP ? {opacity: backdropOpacity} : {}What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
25 remaining items
linhvovan29546 commentedon May 6, 2025
The PR is ready for review!
cc @ikevin127
[-][$250] Desktop - "Select" modal is shown with a blank background[/-][+][Due for payment 2025-05-20] [$250] Desktop - "Select" modal is shown with a blank background[/+]melvin-bot commentedon May 13, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 13, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.44-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 13, 2025
@ikevin127 @strepanier03 @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ikevin127 commentedon May 14, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/55157/files#r2089902934.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition: Resize the Desktop app window to narrow layout size.
Do we agree 👍 or 👎.
strepanier03 commentedon May 20, 2025
Payment summary