Repository navigation
[Due for payment 2025-04-14] [$250] Report- The search doesn't work if display name of user has Double quotes #57086
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.1.0-0
Reproducible in staging?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #56869
Issue reported by: Applause Internal Team
Device used: Macbook/macOS 14.5
App Component: Search
Action Performed:
Precondition: Logged in, A workspace has a member who has Double quotes in his name (e.g: ["" Admin 1802 new])
- Open app
- Click on Reports tab
- Use suuggestion to finish filter with info: status: all, from "" Admin 1802 new, to: BMA Owner 18023
Expected Result:
The value of the from filter should have blue background
Actual Result:
Because "" Admin 1802 new has double quotes so that the system can't recognizes correct syntax. So the value of the from filter doesn't have blue background
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6747493_1739944982707.Recording__293.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021892236526130102736
- Upwork Job ID: 1892236526130102736
- Last Price Increase: 2025-03-05
Issue Owner
Current Issue Owner: @isabelastisserMetadata
Metadata
Labels
Type
Projects
- Status
Activity
melvin-bot commentedon Feb 19, 2025
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Report- The search doesn't work if display name of user has Double quotes[/-][+][$250] Report- The search doesn't work if display name of user has Double quotes[/+]melvin-bot commentedon Feb 19, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021892236526130102736
melvin-bot commentedon Feb 19, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)gurus00 commentedon Feb 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The reports search doesn't work if display name of user has Double quotes
What is the root cause of that problem?
Search query
fromandtorequire to include "" outside of the user nameWhat changes do you think we should make in order to solve the problem?
Enable search with double quotes
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
isabelastisser commentedon Feb 24, 2025
Hey @dukenv0307, please review the proposal when you have a chance. Thanks!
gurus00 commentedon Feb 24, 2025
Please assign it to me. I am confidence to fix this issue soon
55 remaining items
melvin-bot commentedon Apr 7, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 7, 2025
@dukenv0307 @isabelastisser @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
dukenv0307 commentedon Apr 8, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: New feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Apr 14, 2025
Payment Summary
Upwork Job
BugZero Checklist (@isabelastisser)
isabelastisser commentedon Apr 15, 2025
Payment summary:
@codekane $250 via Upwork for proposal JOB
C+ review @dukenv0307 owed $250 via NewDot
isabelastisser commentedon Apr 15, 2025
@codekane what's your Upwork profile?
codekane commentedon Apr 16, 2025
@isabelastisser
https://www.upwork.com/freelancers/~01d2add8e476e785ad
isabelastisser commentedon Apr 16, 2025
Thanks, @codekane! I sent you an offer in Upwork.
All set!
JmillsExpensify commentedon Apr 22, 2025
$250 approved for @dukenv0307