[Due for payment 2025-02-27] [$250] Group - Hover profile of group 6+ members, the tooltip displays five members without ellipsis

@CortneyOfstad

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.95-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Chat Report View

Action Performed:

Open https://staging.new.expensify.com/
Click on group chat having 6+ members
Hover over profile

Expected Result:

Hover over profile, the tooltip should display five members and ellipsis

Actual Result:

Hover over profile, the tooltip is displaying five members as this group only having 5 members

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6736754_1738976735798.Recording__900.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021889709690861886156
Upwork Job ID: 1889709690861886156
Last Price Increase: 2025-02-12
Automatic offers:

daledah | Contributor | 106130113

Issue Owner

Current Issue Owner: @CortneyOfstad

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-02-08 19:21:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

we are only showing 5 users names in the group chat when user hovers over the avatar, but we are not adding the ellipsis for the rest of the names

What is the root cause of that problem?

we are not considering ellipsis here if the the length is more than 5:

App/src/libs/ReportUtils.ts

Line 2584 in 631006e

participantAccountIDs = participantAccountIDs.slice(0, 5);

What changes do you think we should make in order to solve the problem?

we can create a variable like

let shouldUseEllipsis = false;

and here when the length is more than 5 then show ellipsis:

App/src/libs/ReportUtils.ts

Lines 2583 to 2585 in 631006e

    
           if (shouldApplyLimit) { 
        
               participantAccountIDs = participantAccountIDs.slice(0, 5); 
        
           }

as:

    if (shouldApplyLimit) {
        if(participantAccountIDs.length > 5) {
            shouldUseEllipsis = true;
        }
        participantAccountIDs = participantAccountIDs.slice(0, 5);
    }

add the ... in the end here:

App/src/libs/ReportUtils.ts

Lines 2588 to 2597 in 631006e

    
           if (isMultipleParticipantReport) { 
        
               return participantAccountIDs 
        
                   .map( 
        
                       (participantAccountID, index) => 
        
                           getDisplayNameForParticipant({accountID: participantAccountID, shouldUseShortForm: isMultipleParticipantReport}) || formatPhoneNumber(participants?.[index]?.login ?? ''), 
        
                   ) 
        
                   .sort((first, second) => localeCompare(first ?? '', second ?? '')) 
        
                   .filter(Boolean) 
        
                   .join(', '); 
        
           }

as:

               .join(', ') + (shouldUseEllipsis ? '...' : '');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

If we want the ellipsis to be added only in the HeaderView, then:

we can pass a new param like showEllipsis to the getIcons here:

App/src/pages/home/HeaderView.tsx

Line 195 in 631006e

const icons = getIcons(reportHeaderData, personalDetails, null, '', -1, policy, invoiceReceiverPolicy);

Then pass it here to the getGroupChatName:

App/src/libs/ReportUtils.ts

Lines 2764 to 2772 in 631006e

    
           if (isGroupChat(report)) { 
        
               const groupChatIcon = { 
        
                   // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing 
        
                   source: report.avatarUrl || getDefaultGroupAvatar(report.reportID), 
        
                   id: -1, 
        
                   type: CONST.ICON_TYPE_AVATAR, 
        
                   name: getGroupChatName(undefined, true, report), 
        
               }; 
        
               return [groupChatIcon];

and then only add the ellipsis based on this new param

Screen.Recording.2025-02-09.at.12.39.14.AM.mov

The alternative approach will work if we don't want the ellipsis in the details page as shown:

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group - Hover profile of group 6+ members, the tooltip displays five members without ellipsis

What is the root cause of that problem?

If the report has multiple participants we're get the first 5 first participants, then concat them in a single report name

App/src/libs/ReportUtils.ts

Lines 2583 to 2597 in 631006e

    
           if (shouldApplyLimit) { 
        
               participantAccountIDs = participantAccountIDs.slice(0, 5); 
        
           } 
        
           const isMultipleParticipantReport = participantAccountIDs.length > 1; 
        
           if (isMultipleParticipantReport) { 
        
               return participantAccountIDs 
        
                   .map( 
        
                       (participantAccountID, index) => 
        
                           getDisplayNameForParticipant({accountID: participantAccountID, shouldUseShortForm: isMultipleParticipantReport}) || formatPhoneNumber(participants?.[index]?.login ?? ''), 
        
                   ) 
        
                   .sort((first, second) => localeCompare(first ?? '', second ?? '')) 
        
                   .filter(Boolean) 
        
                   .join(', '); 
        
           }

What changes do you think we should make in order to solve the problem?

We have 2 issues here:

The group name doesn't have the ellipsis style
If the participant's display name/login name is too long, then when the user opens the group name settings, this may cause an error without any changes as we limit the maximum name length to 100 characters

We should truncate the group name in

App/src/libs/ReportUtils.ts

Line 2596 in 631006e

.join(', ');

.join(', ').slice(0, 100)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test the getGroupChatName function to verify the output length is less than or equal 100 characters

What alternative solutions did you explore? (Optional)

We can also add the flag to enable/disable this feature in the specific page

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@CortneyOfstad

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Was able to see this within my own account (AM customer group with 7 members and only 5 names displaying, as shown below):

Job added to Upwork: https://www.upwork.com/jobs/~021889709690861886156

Reviewing label has been removed, please complete the "BugZero Checklist".

@dukenv0307

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: error when open group chat with too long name #56927

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

@dukenv0307 requires payment through NewDot Manual Requests
@daledah requires payment automatic offer (Contributor)

@dukenv0307

@dukenv0307 @CortneyOfstad @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@dukenv0307

@dukenv0307 — please complete the checklist by EOD — thanks!

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: This is new requirement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Test:

Start a chat with many members, making the chat name very long
Open Chat details
Verify that: The Group name section the chat name is cut off
Click on Group name
Verify that: No errors is shown

Do we agree 👍 or 👎

@CortneyOfstad

@CortneyOfstad Done. Thank you

@daledah

Payment Summary

@daledah — paid $250 via Upwork
@dukenv0307 — to be paid $250 via NewDot

Regression Test

https://github.com/Expensify/Expensify/issues/474937

@dukenv0307

$250 approved for @dukenv0307

Navigation Menu

Repository navigation

[Due for payment 2025-02-27] [$250] Group - Hover profile of group 6+ members, the tooltip displays five members without ellipsis #56582

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

31 remaining items

BugZero Checklist:

Regression Test Proposal

Test:

Payment Summary

Regression Test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (shouldApplyLimit) {
	participantAccountIDs = participantAccountIDs.slice(0, 5);
	}

	if (isMultipleParticipantReport) {
	return participantAccountIDs
	.map(
	(participantAccountID, index) =>
	getDisplayNameForParticipant({accountID: participantAccountID, shouldUseShortForm: isMultipleParticipantReport}) \|\| formatPhoneNumber(participants?.[index]?.login ?? ''),
	)
	.sort((first, second) => localeCompare(first ?? '', second ?? ''))
	.filter(Boolean)
	.join(', ');
	}

	if (isGroupChat(report)) {
	const groupChatIcon = {
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	source: report.avatarUrl \|\| getDefaultGroupAvatar(report.reportID),
	id: -1,
	type: CONST.ICON_TYPE_AVATAR,
	name: getGroupChatName(undefined, true, report),
	};
	return [groupChatIcon];

	if (shouldApplyLimit) {
	participantAccountIDs = participantAccountIDs.slice(0, 5);
	}
	const isMultipleParticipantReport = participantAccountIDs.length > 1;

	if (isMultipleParticipantReport) {
	return participantAccountIDs
	.map(
	(participantAccountID, index) =>
	getDisplayNameForParticipant({accountID: participantAccountID, shouldUseShortForm: isMultipleParticipantReport}) \|\| formatPhoneNumber(participants?.[index]?.login ?? ''),
	)
	.sort((first, second) => localeCompare(first ?? '', second ?? ''))
	.filter(Boolean)
	.join(', ');
	}

[Due for payment 2025-02-27] [$250] Group - Hover profile of group 6+ members, the tooltip displays five members without ellipsis #56582

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 8, 2025

Shahidullah-Muffakir commented on Feb 8, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

daledah commented on Feb 9, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Feb 12, 2025

CortneyOfstad commented on Feb 12, 2025

melvin-bot commented on Feb 12, 2025

31 remaining items

melvin-bot commented on Feb 20, 2025

melvin-bot commented on Feb 20, 2025

melvin-bot commented on Feb 20, 2025

CortneyOfstad commented on Feb 27, 2025

dukenv0307 commented on Feb 27, 2025

BugZero Checklist:

Regression Test Proposal

Test:

dukenv0307 commented on Feb 27, 2025

CortneyOfstad commented on Feb 27, 2025

Payment Summary

Regression Test

JmillsExpensify commented on Mar 12, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions