Skip to content

Search - Group chat does not appear in search router when group chat only has split expense #56320

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open FAB > Start chat.
  3. Create a group chat with custom group chat name.
  4. Split an expense in the group chat.
  5. Click Search.
  6. Type the group chat name.
  7. Note that the group chat does not exist in the search result.
  8. Send a message to the group chat.
  9. Type the group chat name.
  10. Note that the group chat now exists in the search result.

Expected Result:

In Step 7, the group chat should exist in the search result when the group chat only has split expense (production behavior).

Actual Result:

In Step 7, the group chat does not exist in the search result when the group chat only has split expense.
It only appears in the search result after sending a message to the group chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6732984_1738663955705.20250204_180722.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 4, 2025
  2. melvin-bot commented on Feb 4, 2025

    @melvin-bot

    Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Feb 4, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Feb 4, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Feb 4, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. IuliiaHerets commented on Feb 4, 2025

    @IuliiaHerets
    Author

    Production behaviour

    screen-20250204-123438.mp4
  7. luacmartins commented on Feb 4, 2025

    @luacmartins
    Contributor

    I can take this one since it's Search related

  8. luacmartins commented on Feb 4, 2025

    @luacmartins
    Contributor

    This is the new expected behavior. When we create the group chat without sending a message, the notificationPreferences is set to hidden for all participants. We now hide any reports with notificationPreferences hidden. Once we send a message though, the notificationPreferences is set to always and then the group DM now shows in Search.

    Here are the relevant PRs:

    @IuliiaHerets do we need to update any TCs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions