Repository navigation
Onboarding - "Invite your team" task description is not styled correctly #56308
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests
Action Performed:
- Go to staging.new.expensify.com
- Create a new account.
- Select Manage my team's expenses.
- Selecting any organization size and accounting software.
- Go to #admins
- Open task "Invite your team".
- Go back and open task "Create a workspace".
Expected Result:
"Invite your team" and "Create a workspace" task description will be styled correctly.
Actual Result:
"Invite your team" and "Create a workspace" task description are not styled correctly. Some sentences are completely bold and the bold mark down is shown.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Feb 4, 2025
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 4, 2025
Triggered auto assignment to @nkuoch (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 4, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Feb 4, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Feb 4, 2025
Production behaviour
bandicam.2025-02-04.11-31-56-320.mp4
NJ-2020 commentedon Feb 4, 2025
ishpaul777 commentedon Feb 4, 2025
its coming from -> #55222, confirmed with revert #56313
NJ-2020 commentedon Feb 4, 2025
Oops, Sorry
c3024 commentedon Feb 4, 2025
@Amoralchik
Could you raise a PR?
We should avoid escaping text only for the trackExpense task and not for other tasks.
Here
Amoralchik commentedon Feb 4, 2025
@c3024
I disagree that this is related to my changes. But I agree it's been detected this issue after implementing them.
The main problem is handling
shouldEscapeTextin unescapeText in expensify-common.As we can see, the description starts with the
<strong>tag, which causes the strange "Invite your team*" and only closes this tag after "*Invite member" in list item 4.This happens due to incorrect text processing, and as I noticed during testing, it is related to the presence of ">" in the text.I also need to fix other issues, so anyway I can add this to avoid
shouldEscapeTextfor this text.izarutskaya commentedon Feb 5, 2025
Issue is not reproducible
Recording.2839.mp4
Recording.2975.mp4