[Due for payment 2025-02-18] [Due for payment 2025-02-13] Track expense - App is stuck on the confirmation page when submitting expense to someone

@NicMendonca

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.94-1
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Go to staging.expensify.com
Go to Expenses.
Create an unreported expense (report is set to none).
Log in to staging.new.expensify.com with the same account.
Go to self DM.
Click on the expense created on Old Dot.
Click on the report header.
Click Submit it to someone.
Select any user or workspace.
On confirmation page, click Create button.

Expected Result:

The expense will be submitted to the destination without issue.

Actual Result:

App is stuck on the confirmation page when submitting expense to someone.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6732945_1738660816353.20250204_084504.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @NicMendonca

@techievivek

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@NicMendonca

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Production behaviour

bandicam.2025-02-04.11-33-48-150.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

App is stuck on the confirmation page when submitting expense to someone.

What is the root cause of that problem?

It comes from #55341. When the expense is created in OldDot actionableWhisperReportActionID is undefined then it's stuck here.

App/src/libs/actions/IOU.ts

Lines 4428 to 4430 in 582a892

    
           if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) { 
        
               return; 
        
           }

What changes do you think we should make in order to solve the problem?

Remove !actionableWhisperReportActionID condition here

App/src/libs/actions/IOU.ts

Lines 4428 to 4430 in 582a892

    
           if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) { 
        
               return; 
        
           }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@nkdengineer

Seems like a regression and was already pointed out by the reviewer here https://expensify.slack.com/archives/C01GTK53T8Q/p1738663295636299?thread_ts=1738661984.529329&cid=C01GTK53T8Q, @nkdengineer @allgandalf do you mind taking a look and fixing this up? Thanks.

@techievivek

@techievivek @NicMendonca @techievivek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging]fix: App is stuck on the confirmation page when submitting expense #56397

If no regressions arise, payment will be issued on 2025-02-18. 🎊

@techievivek

@techievivek @NicMendonca @techievivek The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

@NicMendonca

@NicMendonca, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

No need for BZ checklist, it was a regression and was fixed by the original author. Closing this since we don't need to make any payment here.

Navigation Menu

Repository navigation

[Due for payment 2025-02-18] [Due for payment 2025-02-13] Track expense - App is stuck on the confirmation page when submitting expense to someone #56307

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

14 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (!linkedTrackedExpenseReportAction \|\| !actionableWhisperReportActionID \|\| !linkedTrackedExpenseReportID) {
	return;
	}

[Due for payment 2025-02-18] [Due for payment 2025-02-13] Track expense - App is stuck on the confirmation page when submitting expense to someone #56307

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 4, 2025

melvin-bot commented on Feb 4, 2025

melvin-bot commented on Feb 4, 2025

github-actions commented on Feb 4, 2025

IuliiaHerets commented on Feb 4, 2025

mkzie2 commented on Feb 4, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

techievivek commented on Feb 4, 2025

14 remaining items

melvin-bot commented on Feb 6, 2025

melvin-bot commented on Feb 11, 2025

melvin-bot commented on Feb 11, 2025

NicMendonca commented on Feb 13, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

melvin-bot commented on Feb 17, 2025

techievivek commented on Feb 17, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions