Skip to content

Search - No results triggered when searching for valid words in chat search. #56028

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+227@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Search

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Open any chat.
  3. Send some messages to the chat.
  4. Tap on the search icon on the top right corner.
  5. Tap on "Search in this chat"
  6. Write a word that should trigger results.

Expected Result:

Correct content should be displayed after the user searches for any word included in a conversation.

Actual Result:

No results are triggered after the user searches for valid words in chat search.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6728116_1738204523211.Results.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 30, 2025
  2. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Jan 30, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jan 30, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. techievivek commented on Jan 30, 2025

    @techievivek
    Contributor

    We can certainly demote this since it seems to be working all chats but workspace.

  7. techievivek commented on Jan 30, 2025

    @techievivek
    Contributor

    @luacmartins I tested this across various chats and it seems to be working for most except the workspace chat, I looked at the response data for WS chat and it seems like backend is not returning anything. Would you want to take over this?

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 30, 2025
  9. luacmartins commented on Jan 30, 2025

    @luacmartins
    Contributor

    Yea, I can look into this

  10. melvin-bot commented on Feb 3, 2025

    @melvin-bot

    @luacmartins, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. isabelastisser commented on Feb 4, 2025

    @isabelastisser
    Contributor

    any updates here, @luacmartins thank you!

  12. luacmartins commented on Feb 4, 2025

    @luacmartins
    Contributor

    Not yet, I'll look into it this week

  13. luacmartins commented on Feb 5, 2025

    @luacmartins
    Contributor

    I'm unable to reproduce this issue in the selfDM like shown in the OP. As for the workspace chat, like @techievivek mentioned, that's the expected behavior because in the Workspace chat the default behavior is searching for expenses, not chats. So you'd have to change the type to chat to see the results. When I do that, I can find them without issues.

    Gonna close this issue. Please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions