Repository navigation
[HOLD for payment 2025-02-07] [Due for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file #55937
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.91-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat.
- Click + > Create expense > Manual.
- Enter amount > Next.
- On the confirmation page, drag and drop an invalid file format to the RHP.
- Note that it shows error modal.
- Drag and drop a valid file.
- Drag and drop another valid file (to show that we can drag and drop file to replace current file).
- Drag and drop an invalid file.
Expected Result:
App will show error modal.
Actual Result:
App does not show error modal when drag and drop an invalid file to replace current file.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6727168_1738142472297.no_error.mp4
file for step 9 (please unzip)
Bug6727168_1738142472292!AnnoyingOrangeAnimator.webp.zip
Activity
melvin-bot commentedon Jan 29, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 29, 2025
Triggered auto assignment to @Beamanator (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 29, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 29, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Beamanator commentedon Jan 29, 2025
Discussing in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1738148050803679
Beamanator commentedon Jan 29, 2025
PR reverted & CP'd, QA should test before marking this NAB 🙏
2 remaining items
[-]Expense - No error modal when drag and drop an invalid file to replace current file[/-][+][HOLD for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file[/+]melvin-bot commentedon Jan 30, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-06. 🎊
melvin-bot commentedon Jan 30, 2025
@Beamanator @RachCHopkins @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file[/-][+][Due for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file[/+]RachCHopkins commentedon Jan 30, 2025
@Beamanator do I actually need to pay anyone here?
Beamanator commentedon Jan 30, 2025
aah nope you're good, the PR fixing this was a straight revert so nope! 👍
[-][Due for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file[/-][+][HOLD for payment 2025-02-07] [Due for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file[/+]melvin-bot commentedon Jan 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-07. 🎊
melvin-bot commentedon Jan 31, 2025
@Beamanator @RachCHopkins @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]