[Due for payment 2025-02-27] [$250] Company cards - Netsuite - Wrong account name in preview for journal entries accounts

@abekkala

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.89-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome
App Component: Workspace Settings

Action Performed:

Pre-requisite:

User must have assigned a few company cards
User have enable Accounting and connected to Netsuite

Go to Workspace settings > Company cards
Click on an assigned card
Click on NetSuite vendor bills export
Click on "export option" highlighted text in the subheader
Click on "Export company card expenses as:" field
Click on "Export as:"
Select Journal entries
Go back to card details
Click on NetSuite journal entries export
Click on a different account, note the displayed name
Verify the selected account in the preview

Expected Result:

The name of the journal entry account displayed in the preview should be the same as in the list

Actual Result:

The name of the journal entry account displayed in the preview is not the same as in the list

Workaround:

Unknown

Platforms:

Screenshots/Videos

bandicam.2025-01-24.13-38-07-225.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021885426285334547544
Upwork Job ID: 1885426285334547544
Last Price Increase: 2025-01-31
Automatic offers:

shubham1206agra | Contributor | 106076552

Issue Owner

Current Issue Owner: @abekkala

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@joekaufmanexpensify

@joekaufmanexpensify We found this issue when writing the TestRail regression steps for Company Cards

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 21:37:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - Netsuite - Wrong account name in preview for journal entries accounts

What is the root cause of that problem?

In

App/src/pages/workspace/companyCards/utils.tsx

Line 20 in f4c3726

function getExportMenuItem(

We accidentally override title in this case shown below

App/src/pages/workspace/companyCards/utils.tsx

Line 202 in f4c3726

    
           title = companyCard?.nameValuePairs?.netsuite_export_payable_account ?? data.find((exportPayable) => exportPayable.isSelected)?.text;

Which causes the wrong account name in preview.

What changes do you think we should make in order to solve the problem?

Remove

App/src/pages/workspace/companyCards/utils.tsx

Line 202 in f4c3726

    
           title = companyCard?.nameValuePairs?.netsuite_export_payable_account ?? data.find((exportPayable) => exportPayable.isSelected)?.text;

to fix the issue.

Result

Screen.Recording.2025-01-25.at.3.09.45.AM.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA since this is a UI bug

What alternative solutions did you explore? (Optional)

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

Agreed, this seems like a bug.

@abekkala

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@abekkala

@abekkala Eep! 4 days overdue now. Issues have feelings too...

Job added to Upwork: https://www.upwork.com/jobs/~021885426285334547544

Reviewing label has been removed, please complete the "BugZero Checklist".

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fixed wrong account name in preview for journal entries accounts #56909

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment through NewDot Manual Requests
@shubham1206agra requires payment automatic offer (Contributor)

@hungvu193

@hungvu193 / @shubham1206agra @abekkala @hungvu193 / @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@shubham1206agra

PAYMENT SUMMARY FOR FEB 27

Fix: @shubham1206agra [$250, if no regressions] payment via NewDot
PR Review: @hungvu193 [$250, if no regressions] payment via NewDot
please complete checklist

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/52180/files#r1969198462
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/474110

Regression Test Proposal

Precondition:

User must have company cards
User must have workspace that connected to Netsuite

Test:

Go to Workspace settings > Company cards.
Click on an assigned card.
Click on NetSuite vendor bills export.
Click on "export option" highlighted text in the subheader.
Click on "Export company card expenses as:" field.
Click on "Export as:".
Select Journal entries.
Go back to card details.
Click on NetSuite journal entries export.
Click on a different account, note the displayed name.
Verify that the name of the journal entry account displayed in the preview should be the same as in the list.

Do we agree 👍 or 👎

@shubham1206agra

PAYMENT SUMMARY FOR FEB 27

Fix: @shubham1206agra [$250, if no regressions] payment via NewDot
PR Review: @hungvu193 [$250, if no regressions] payment via NewDot

@hungvu193

$250 approved fro @hungvu193

@shubham1206agra

$250 approved for @shubham1206agra

Navigation Menu

Repository navigation

[Due for payment 2025-02-27] [$250] Company cards - Netsuite - Wrong account name in preview for journal entries accounts #55753

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

30 remaining items

PAYMENT SUMMARY FOR FEB 27

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

PAYMENT SUMMARY FOR FEB 27

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2025-02-27] [$250] Company cards - Netsuite - Wrong account name in preview for journal entries accounts #55753

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jan 24, 2025

isagoico commented on Jan 24, 2025

shubham1206agra commented on Jan 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

github-actions commented on Jan 24, 2025

joekaufmanexpensify commented on Jan 24, 2025

melvin-bot commented on Jan 28, 2025

melvin-bot commented on Jan 30, 2025

melvin-bot commented on Jan 31, 2025

30 remaining items

melvin-bot commented on Feb 20, 2025

melvin-bot commented on Feb 20, 2025

melvin-bot commented on Feb 20, 2025

abekkala commented on Feb 20, 2025

PAYMENT SUMMARY FOR FEB 27

hungvu193 commented on Feb 25, 2025

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

abekkala commented on Feb 25, 2025

PAYMENT SUMMARY FOR FEB 27

garrettmknight commented on Feb 28, 2025

garrettmknight commented on Apr 22, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions