Repository navigation
[HOLD for payment 2025-01-30] [HOLD for payment 2025-01-28] iOS Workspace features - No animation in workspace editor after enabling feature #55413
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.87-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): iPhone 15 Pro Max / iOS 18.2
Issue reported by: Applause Internal Team
Device used: applausetester+100106kh@applause.expensifail.com
App Component: Workspace Settings
Action Performed:
- Launch ND or hybrid app.
- Go to workspace settings > More features.
- Enable Workflows.
Expected Result:
There will be animation in workspace editor when app returns to workspace editor after enabling Workflows (production behavior).
Actual Result:
There is no animation in workspace editor when app returns to workspace editor after enabling Workflows.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @AndrewGable (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jan 17, 2025
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 17, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jan 17, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
AndrewGable commentedon Jan 17, 2025
I can confirm the issue but not super clear to me yet what code added this
AndrewGable commentedon Jan 17, 2025
The only thing I can see is these changes: #53938, but not really sure how they relate as it seems like the code that does this navigating and animation is not changed.
@thesahindia @mountiny @sumo-slonik - Would you mind checking to see if this PR introduced this?
mountiny commentedon Jan 18, 2025
@thesahindia could you test a revert PR if this is coming from our PR? Thank you!
23 remaining items
[-][HOLD for payment 2025-01-28] iOS Workspace features - No animation in workspace editor after enabling feature[/-][+][HOLD for payment 2025-01-30] [HOLD for payment 2025-01-28] iOS Workspace features - No animation in workspace editor after enabling feature[/+]melvin-bot commentedon Jan 23, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.88-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-30. 🎊
melvin-bot commentedon Jan 23, 2025
@AndrewGable @isabelastisser @AndrewGable The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jan 30, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Jan 30, 2025
@AndrewGable, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
isabelastisser commentedon Jan 30, 2025
@AndrewGable, do we need a regression test here?
AndrewGable commentedon Jan 30, 2025
No I don't think so!
isabelastisser commentedon Jan 30, 2025
Thanks for confirming! Closing this since no payment is needed.