Skip to content

[Due for payment 2025-02-13] Create mocks for Settle up feature for workspace feeds #55158

Closed

Description

@mountiny

Problem

When customers have Expensify cards set up on workspace with monthly settlement frequency (not applicable for daily settlement frequency), then they might be approaching their limit even before the end of the monthly billing. In such case, they need to be able to settle up early. Right now, there is no way to do this in NewDot.

Solution

This should be done using a Settle up button on the Expensify card page, which policy admins can access. When this button is clicked, we call Domain_QueueExpensifyCardForBilling(authToken, domainName, feedCountry) command and the billing is queued for later in the day.

Note that this action is not immediate. The settling up will happen in the next day, so we need to communicate that to the admin. @jamesdeanexpensify, would you be able to help with the copy here, please?

When this happens, we set the private_expensifyCardManualBilling for the domain account with value true. If this value is true, we should update the UI to indicate the admin that this is queued and the limit should be cleared in the next 24 hours once the payment happens.

We need to return the NVP on the Expensify card page so we can show the correct state of the Settle up button to other admins too.

Image

Image

Image

cc @nkuoch

Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    Current assignee @jamesdeanexpensify is eligible for the Waiting for copy assigner, not assigning anyone new.

  2. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jan 13, 2025

    @melvin-bot

    Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

  4. mountiny commented on Jan 13, 2025

    @mountiny
    ContributorAuthor
  5. 51 remaining items

  6. changed the title [-]Create mocks for Settle up feature for workspace feeds[/-] [+][Due for payment 2025-02-13] Create mocks for Settle up feature for workspace feeds[/+] on Feb 6, 2025
  7. melvin-bot commented on Feb 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  8. melvin-bot commented on Feb 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @koko57 does not require payment (Contractor)
  9. melvin-bot commented on Feb 6, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@koko57] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  10. melvin-bot commented on Feb 13, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  11. lschurr commented on Feb 13, 2025

    @lschurr
    Contributor

    Payment summary is correct - no payments since everyone assigned is an employee or contractor. Closing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2DesignNewFeatureSomething to build that is a new item.Waiting for copyUser facing verbiage needs polishing

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions