Repository navigation
[$500] [Due for payment 2025-02-13] [Add onboarding for new workspaces being created] Create new setup tasks when users create a workspace #53509
Description
Part of the project "Adding onboarding for new workspaces being created"
Main issue: #48591
Doc section: https://docs.google.com/document/d/19u6ZQbNuF-v5oovIkQlmwYV4SXeAgey50pymsj5QHRY/edit?tab=t.0#heading=h.vwt3yefp8jmh (External only)
Feature Description
When a user who didn't choose the option "Manage my team's expenses" during the initial onboarding eventually creates a workspace, create onboarding tasks to teach them what to do next.
Implementation steps
-
Prep work:
- Add new constant
newDotTrackWorkspacetobackendOnboardingChoices- Design doc section - Extract the logic to generate the request and optimistic data for onboarding tasks out of
completeOnboarding(), for clarity and reusability – Design doc section
- Add new constant
-
Create new setup tasks when users create a workspace
- Design doc section ('External' section only)
- Update
CategorizeTrackedExpense,ShareTrackedExpense, andCreateWorkspaceto generate and pass the new onboarding task data to the API if the user doesn't already have acreateWorkspaceonboarding task
Activity
francoisl commentedon Dec 4, 2024
(Keeping internal because we're going to work with a C+ on this)
mananjadhav commentedon Dec 5, 2024
Reviewed the design document. Will take another pass to see if there are any gaps. Will start with the implementation by tomorrow.
mananjadhav commentedon Dec 10, 2024
@francoisl Is there anything pushed on the backend to start this?
francoisl commentedon Dec 10, 2024
One part is deployed, another one won't be until at least tomorrow, and the tasks won't be saved until both parts are.
For now, the part 1 "Prep work" I described above shouldn't require any backend changes. Also, for step 2 we can start saving the task data in the optimistic data of the API request, and test it offline?
francoisl commentedon Dec 12, 2024
@mananjadhav the backend changes for passing
guidedSetupDataandengagementChoiceto the API commandsCategorizeTrackedExpense,ShareTrackedExpense, andCreateWorkspaceare now live. Let me know if anything is not working as expected.mananjadhav commentedon Dec 12, 2024
Okay thanks. I'll check those and reach out to you if any questions.
mananjadhav commentedon Dec 16, 2024
Started with this, the PR will be up by tomorrow.
melvin-bot commentedon Dec 19, 2024
@francoisl, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!
68 remaining items
mallenexpensify commentedon Feb 23, 2025
We def want regression tests for new features, sometimes they're created all at once as part of a project and sometimes they're done per feature. @francoisl do you know how we want to handle here? Thx
melvin-bot commentedon Feb 24, 2025
@francoisl, @mananjadhav, @mallenexpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!
mananjadhav commentedon Feb 25, 2025
Quick bump @francoisl
francoisl commentedon Feb 26, 2025
I opened an internal issue to create the regression tests
https://github.com/Expensify/Expensify/issues/474370
francoisl commentedon Feb 26, 2025
@mallenexpensify as far as I can tell, we just need to issue the payments and close this?
parasharrajat commentedon Feb 27, 2025
Looks like PR of this isue caused an issue #57499
ishpaul777 commentedon Feb 27, 2025
not denying, but can you help me understand reason for your suspicion @parasharrajat also I am not able to reproduce the issue
parasharrajat commentedon Feb 27, 2025
Try to fail the workspace creation with an error, and it will create that issue. I checked the onyx keys that affect that UI state and all of them were present in the failure state.
It might be backend but if you can give it a try and confirm this, it would be great.
mallenexpensify commentedon Feb 28, 2025
Going to wait a min for payment, pending potential regression. Note to self to check the regression timeline/window too.
ishpaul777 commentedon Mar 1, 2025
I tried to simulate as shown in video of issue but I could not get such error when using
Troubleshoot -> Simulate failing network requestsmananjadhav commentedon Mar 3, 2025
I cannot reproduce it either.
@mallenexpensify This issue was supposed to be closed by Feb 13 and I think it's already paid out. I think we should close this issue and discuss in the linked issue.