Skip to content

[Due for payment 2025-02-13] [$250] Pasting data in chat puts the cursor in the wrong position #40025

Closed

Description

@iwiznia

Reported here https://expensify.slack.com/archives/C049HHMV9SM/p1712763627228909

Happening on staging but not on prod.

Steps:

  • Copy some text
  • Paste it in the chat box
  • Cursor is at the beginning of the line, but it should be at the end
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0166be7baac5afe84f
  • Upwork Job ID: 1780997931107999744
  • Last Price Increase: 2025-01-14
  • Automatic offers:
    • QichenZhu | Contributor | 105706923
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 10, 2024
  2. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Apr 10, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. iwiznia commented on Apr 10, 2024

    @iwiznia
    ContributorAuthor

    Seems I can't reproduce it anymore 🤷

  6. Julesssss commented on Apr 10, 2024

    @Julesssss
    Contributor

    Thank fuck for that

  7. lanitochka17 commented on Apr 18, 2024

    @lanitochka17

    Issue is still reproducible on the latest build 1.4.63-0
    mWeb/Chrome

    cursorled.mp4
  8. 100 remaining items

  9. changed the title [-][$250] Pasting data in chat puts the cursor in the wrong position[/-] [+][Due for payment 2025-02-13] [$250] Pasting data in chat puts the cursor in the wrong position[/+] on Feb 6, 2025
  10. melvin-bot commented on Feb 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Feb 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.94-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-13. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Feb 6, 2025

    @melvin-bot

    @jjcoffee @RachCHopkins @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. jjcoffee commented on Feb 13, 2025

    @jjcoffee
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/react-native-live-markdown/pull/450/files#r1954219567

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Android Chrome with Samsung keyboard

    Test:

    1. Copy some text, e.g. "aaa" and go to any chat.
    2. Use the device keyboard to input "aaa"
    3. Send the message.
    4. Right click or long press the Composer to show the context menu and click Paste.
    5. Verify that the copied text pastes into the Composer and the caret is at the end.

    Do we agree 👍 or 👎

  14. RachCHopkins commented on Feb 14, 2025

    @RachCHopkins
    Contributor

    Payment Summary:

    • Contributor: @QichenZhu to be paid $250 via Upwork
    • Contributor+: @jjcoffee to be paid $250 via NewDot manual request

    Upwork job here

  15. RachCHopkins commented on Feb 14, 2025

    @RachCHopkins
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

  16. garrettmknight commented on Feb 19, 2025

    @garrettmknight
    Contributor

    $250 approved for @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions