Repository navigation
feat(cascade): report duplicate index primary keys - #535
Open
chuiwenwei wants to merge 1 commit into
Open
chuiwenwei wants to merge 1 commit into
chuiwenwei wants to merge 1 commit into
Conversation
LanceDB has no unique constraint, so a write path that bypasses the merge helper can leave two rows for one (app_id, project_id, id). The next write may pick one arbitrarily and search silently loses the other. Add an opt-in `everos cascade status --duplicates` scan: it counts extra rows per logical key in every business table, backend-neutrally, and prints them beside the existing live row counts. The scan is O(N) per table, so it stays off the default status path. Refs EverMind-AI#479.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LanceDB has no unique constraint, so a write path that bypasses the merge
helper can leave two rows for one
(app_id, project_id, id). The nextcascade write may pick one arbitrarily and search silently loses the
other. Add an opt-in
everos cascade status --duplicatesscan that countsextra rows per logical key in every business table.
The scan is O(N) per table, so it stays off the default status path.
Closes #479.
Area
Verification
The full unit suite will run in CI; the local run was stopped under host
load after the targeted tests passed.
Checklist
main..envfiles, dependency folders, or generated output.Notes for Reviewers
cascade statusstays cheap for normal use.should report zero.
docs/cli.mdanddocs/cascade_runbook.mddescribe the new flag.By submitting this pull request, I agree that my contribution is licensed under
the Apache License 2.0.