Repository navigation
fix(search): bridge agent skills on md entry ids - #513
Open
chuiwenwei wants to merge 1 commit into
Open
chuiwenwei wants to merge 1 commit into
chuiwenwei wants to merge 1 commit into
Conversation
7 of 12 tasks
The reverse case→skill bridge keyed on Candidate.id, the index row id (<owner>_ac_<date>_<seq>). SKILL.md's source_case_ids stores the md-side entry id (ac_<date>_<seq>), so the two never matched and the bridge could not return a skill. Carry the entry id from the case shaper in a private DTO attribute and build the internal bridge candidates on it. The public response keeps the index row id; only the internal key changes. Regression tests pin both the shaper hand-off and the bridge construction. Refs EverMind-AI#478.
chuiwenwei
force-pushed
the
fix/skill-bridge-entry-id
branch
from
October 20, 2026 13:00
b786709 to
d81c112
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reverse case→skill bridge keyed on
Candidate.id, the index row id(
<owner>_ac_<date>_<seq>).SKILL.md'ssource_case_idsstores themd-side entry id (
ac_<date>_<seq>), so the two never matched and thebridge could not return a skill.
Carry the entry id from the case shaper in a private DTO attribute and
build the internal bridge candidates on it. The public response keeps
the index row id; only the internal bridge key changes.
Closes #478.
Area
Verification
Additional tests:
tests/unit/test_memory/test_search/test_shaper.py— the shaper carriesthe md-side
entry_idinto the private DTO attribute; the publicidremains the index row id.
tests/unit/test_memory/test_search/test_manager.py— the bridgereceives
ac_...(not<owner>_ac_...) and max-pools the matched casescore; the existing end-to-end bridge test now uses the real ID shape.
Checklist
main..envfiles, dependency folders, or generated output.Notes for Reviewers
schema is unchanged.
SearchAgentCaseItem._entry_idis a PydanticPrivateAttr: it is neverserialized, so the public schema and response are unchanged.
falling back to the row id (which can never match
source_case_ids).source_case_ids; I chosethe internal entry-id path because it does not rewrite existing skills.
By submitting this pull request, I agree that my contribution is licensed under
the Apache License 2.0.