Skip to content

Broken Import: handle strings with double quotes and strings with single-quote/comma #95

Open

Description

@rhodges

single quotes are escaped with another single quote: "he'll" becomes "he''ll"

If that single quote (or apostrophe) is right before a comma, that breaks the current regex pattern:
eg_match = r'(E'".+?(?!\)"'|E'.*?(?!\)'|.+?)(?:,\s|$)'
import_sql near line 180

It also fails on strings with double quotes, which switch from:
E'I'm a string!'
to
E'I'm a "string"!'
so that it can be single quoted

Activity

  1. added this to the Final milestone on Oct 30, 2017
  2. self-assigned this
    on Oct 30, 2017
  3. rhodges commented on Oct 31, 2017

    @rhodges
    MemberAuthor

    gave all str() functions "or ''" so 'NoneType' was never returned. Trying to str that was breaking everything.

  4. rhodges commented on Nov 1, 2017

    @rhodges
    MemberAuthor

    Here's an example to test against:
    'E'There were things at place, (999) xx''x xx''xxx''x''9,'', "thing preposition verbed," but thing2 stuff, "new statement."', E'0', E'0', E'0''
    should parse to [(string), "E'0'", E'0'", E'0'"] (len: 4)

  5. reopened this on Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions