Repository navigation
Conversation
…ls auth phpRedisAdmin 1.27.0 answers every request with 403 unless a login, login_as_acl_auth or allow_no_auth is configured, and EasyEngine's config sets none of them, so /ee-admin/pra/ is a 403 on every install since that release. /ee-admin/ is already behind the admin-tools basic auth, so set allow_no_auth when no ADMIN_USER login is configured. Installs that already fetched 1.27.0 keep the old config file, so install() now rewrites the pra config when it differs from the template, as it already does for index.php.
There was a problem hiding this comment.
🟢 Approval recommended
The targeted changes address the authentication failure and existing installations without identified blocking issues.
No open issues 🎉
What changed in this PR
Restores phpRedisAdmin access behind EasyEngine’s admin-tools authentication for version 1.27.0 and later.
Changes:
- Allows phpRedisAdmin to run without its own login when
ADMIN_USERis unset. - Refreshes existing phpRedisAdmin configurations when they differ from the template.
| File | Description |
|---|---|
| templates/pra.config.mustache | Enables allow_no_auth when no application login is configured. |
| src/Admin_Tools_Command.php | Refreshes outdated phpRedisAdmin configuration during installation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
phpRedisAdmin 1.27.0 (released 2026-10-19) refuses to run unless
$config['login'],login_as_acl_authorallow_no_authis set, and answers every request with HTTP 403 "Authentication is required. Configure login credentials or explicitly set allow_no_auth…" (includes/common.inc.php).install_pra()fetches the latest release, andtemplates/pra.config.mustachesets none of those options, so/ee-admin/pra/is a 403 on every admin-tools install since that release.Fix
templates/pra.config.mustache: set$config['allow_no_auth'] = truewhen noADMIN_USERlogin is configured./ee-admin/is already behind the admin-tools basic auth, so phpRedisAdmin doesn't need its own login. The assignment comes after theconfig.sample.inc.phpinclude, which sets it tofalsein 1.27.0.install(): rewriteadmin-tools/pra/includes/config.inc.phpwhen it differs from the template, the same wayindex.phpis already refreshed, so installs that already fetched 1.27.0 recover on the nextee admin-tools enable.Testing
phpRedisAdmin 1.27.0 and 1.26.0 (with predis 1.1.1, as
install_pra()assembles them), each with the old and the new config, served by PHP 7.4 and 8.5 against a Redis container:ADMIN_USERADMIN_USERsetBehat scenarios for this (pra served on a site with cache, and an old config refreshed by
ee admin-tools enable --force) follow with the suite in #55.