Repository navigation
Fix Deg2Rad and Rad2Deg being swapped in Natives.lua - #12
Open
mdlsvensson wants to merge 1 commit into
Open
mdlsvensson wants to merge 1 commit into
mdlsvensson wants to merge 1 commit into
Conversation
Deg2Rad was math.deg and Rad2Deg math.rad, so Deg2Rad(180) gave 10313.24 instead of pi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Natives.luasetsDeg2Rad = math.degandRad2Deg = math.rad, the wrong way round.Checked in 5.3 (
print(Deg2Rad(180), Rad2Deg(math.pi))after loading the file):10313.240312355 0.0548311355616083.1415926535898 180.0My fork has used this fix since october