Skip to content

Proposal: Permanently disable rule SA1409 #1058

Closed

Description

@sharwell

Rule SA1409 (RemoveUnnecessaryCode) has two characteristics which make it a particularly poor rule for StyleCopAnalyzers:

  • It is poorly defined (what is or is not "necessary"?)
  • It is largely a semantic rule as opposed to a syntax-based style rule

I propose rule SA1409 be permanently disabled, and allow other tools which focus on semantics (e.g. a future "FxCopAnalyzers") to pick up this diagnostic at a later time.

Activity

  1. Noryoko commented on Jul 26, 2015

    @Noryoko
    Contributor

    I agree. This should be handled by something like FxCopAnalyzers.

  2. pdelvo commented on Jul 26, 2015

    @pdelvo
    Member

    👍

  3. added this to the 1.0.0 Beta 2 milestone on Jul 26, 2015
  4. self-assigned this
    on Jul 26, 2015
  5. added a commit that references this issue on Jul 26, 2015
    12e61ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions