Repository navigation
Support HTTP-Keep-Alive in our XMLHttpRequest implementation - #354
Merged
Merged
Conversation
Passing an object to `new Error` will result in `Error: [object Object]`.
Xmader
changed the title
XMLHttpRequest implementationXMLHttpRequest implementation
…stem calls that open a TCP connection
Xmader
marked this pull request as ready for review
May 30, 2024 18:46
Contributor
|
Looks good. Can you tell us more about the determination of the timeout value? |
philippedistributive
previously approved these changes
Jun 3, 2024
5s is the default for Node.js's `http.globalAgent`, see the change history in https://nodejs.org/dist/latest/docs/api/http.html#httpglobalagent
Member
Author
|
I changed the timeout to 5s, because 5s is the default for Node.js's |
philippedistributive
approved these changes
Jun 4, 2024
This was referenced Jun 12, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #339