Repository navigation
Conversation
Add a test that the renovate config shipped to downstream projects disables updates for every base image in the generated Dockerfile, and clarify this in the renovate how-to.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336
Summary
Add a regression test and documentation ensuring the Renovate configuration shipped to downstream repos keeps base image updates disabled, completing the work started in #365 for #336.
Changes
tests/test_example.py: Addedtest_renovate_dockerfile_base_images_match_what_is_shippedto verify that all external base images in generated Dockerfiles remain disabled inpackageRules.docs/how-to/renovate.md: Clarified that template-managed base images are intentionally excluded from downstream updates; fixed a typo.Verification
uv run --locked tox -e tests(passes; verified failure by intentionally swapping the runtime base image).uv run --locked tox -e pre-commit.renovate --platform=local --dry-run=lookup(both base images reportskipReason: "disabled").