Repository navigation
ci: let cancel-in-progress cancel the container job - #1709
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 49 49
Lines 3711 3711
=======================================
Hits 3578 3578
Misses 133 133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
force-pushed
the
cancel-container-build
branch
from
October 20, 2026 15:37
e1f6487 to
da74204
Compare
ZohebShaikh
changed the title
ZohebShaikh
force-pushed
the
remove-timeout-check
branch
from
October 21, 2026 07:54
a3e4935 to
b3c5f33
Compare
always() keeps the job running when the workflow is cancelled; !cancelled() still runs it after test failures but respects cancellation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ZohebShaikh
force-pushed
the
cancel-container-build
branch
from
October 21, 2026 08:10
da74204 to
c3c5d54
Compare
2 tasks
fajinyuan
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
containerusedif: always(), which keeps the job running (or starts it) after the workflow is cancelled, socancel-in-progressnever stopped the container build.!cancelled()still runs it after test failures (needed for thepublishinput) but respects cancellation.One-line change to
.github/workflows/ci.yml, based directly onmain.Test plan
containerjob shows as cancelled🤖 Generated with Claude Code