Repository navigation
feat: Use websockets if stomp config not present - #1646
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
==========================================
+ Coverage 96.41% 96.43% +0.01%
==========================================
Files 49 49
Lines 3711 3728 +17
==========================================
+ Hits 3578 3595 +17
Misses 133 133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tpoliaw
force-pushed
the
scripting-ws
branch
from
September 2, 2026 15:17
5b426af to
0c5bbe1
Compare
tpoliaw
changed the title
tpoliaw
commented
Sep 2, 2026
| return cls(rest) | ||
|
|
||
| @classmethod | ||
| def for_host(cls, host: str | None = None) -> Self: |
Contributor
Author
There was a problem hiding this comment.
Not sure what this should be called. for_host doesn't make sense when called as for_host() to use the default.
tpoliaw
force-pushed
the
scripting-ws
branch
from
September 14, 2026 20:04
0c5bbe1 to
e127001
Compare
It's probably useful to have a single search to cover both
Contributor
|
@tpoliaw Are you working secretly 😄 ? |
fajinyuan
approved these changes
Oct 21, 2026
ZohebShaikh
pushed a commit
that referenced
this pull request
Nov 2, 2026
Update the client's run_task method to use stomp if the configuration is present and fall back to the new websocket connection if not. Allows the scripting interface (bc.plans.count(...)) to run without configuration using websockets. The CLI also defaults to websockets if no configuration is present. To force stomp monitoring, a new --stomp flag is added to be paired with the --ws flag. The previous run_task method on BlueapiClient has been renamed to run_stomp and run_task will delegate to the correct method depending on the configuration available. This should not be a breaking change as there is no change in behaviour if configuration is present. --------- Co-authored-by: Dr Fajin Yuan <fajin.yuan@diamond.ac.uk>
ZohebShaikh
pushed a commit
that referenced
this pull request
Nov 2, 2026
Update the client's run_task method to use stomp if the configuration is present and fall back to the new websocket connection if not. Allows the scripting interface (bc.plans.count(...)) to run without configuration using websockets. The CLI also defaults to websockets if no configuration is present. To force stomp monitoring, a new --stomp flag is added to be paired with the --ws flag. The previous run_task method on BlueapiClient has been renamed to run_stomp and run_task will delegate to the correct method depending on the configuration available. This should not be a breaking change as there is no change in behaviour if configuration is present. --------- Co-authored-by: Dr Fajin Yuan <fajin.yuan@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the client's run_task method to use stomp if the configuration is present
and fall back to the new websocket connection if not.
Allows the scripting interface (bc.plans.count(...)) to run without
configuration using websockets.
The CLI also defaults to websockets if no configuration is present. To force
stomp monitoring, a new --stomp flag is added to be paired with the --ws flag.
The previous run_task method on BlueapiClient has been renamed to run_stomp and
run_task will delegate to the correct method depending on the configuration
available. This should not be a breaking change as there is no change in
behaviour if configuration is present.