Repository navigation
refactor: Add defaults for authZ policy - #1621
Merged
ZohebShaikh merged 1 commit intoAug 17, 2026
Merged
Conversation
ZohebShaikh
force-pushed
the
add-defaults-for-policy
branch
from
August 11, 2026 15:43
4b7c6c4 to
fab42ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1621 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 45 45
Lines 3318 3318
=======================================
Hits 3184 3184
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
changed the title
Contributor
Author
|
@shree-iyengar-dls If this change gets merged in Then the only docs that should be added is that please point it to the authorization provider which is opa.diamond.ac.uk |
ZohebShaikh
force-pushed
the
add-defaults-for-policy
branch
from
August 17, 2026 12:25
a2eb261 to
2130fd4
Compare
Contributor
Author
|
@DiamondLightSource/developers-daq-core Can anyone in our team have a look at this PR? |
tpoliaw
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It feels slightly awkward to have to specify the policy values explicitly. I think having sensible defaults would provide a better UX.
They could also be included in Copier, but having them as defaults would mean one less thing to worry about when running
copier update.