Skip to content

chore: update pre-commit hooks - #1583

Merged
ZohebShaikh merged 7 commits into
mainfrom
update-pre-commit-hoos
Jul 7, 2026
Merged

ZohebShaikh merged 7 commits into
mainfrom
update-pre-commit-hoos

Conversation

@ZohebShaikh

@ZohebShaikh ZohebShaikh commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor
  1. Decouple pyright version from uv.lock file
  2. Update asyncapi check file to a more maintained project
  3. Update all pre-commit hooks
  4. Use docker images instead of raw builds to make it easier to work on dls workstations

@ZohebShaikh
ZohebShaikh requested a review from a team as a code owner June 30, 2026 15:49
@codecov

codecov Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.91%. Comparing base (32c57b9) to head (b59f599).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   95.93%   95.91%   -0.03%     
==========================================
  Files          44       44              
  Lines        3270     3254      -16     
==========================================
- Hits         3137     3121      -16     
  Misses        133      133              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shree-iyengar-dls shree-iyengar-dls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could update actions/checkout version

Comment thread .github/workflows/asyncapi.yml Outdated
@@ -19,6 +19,7 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could update actions/checkout to v7? actions/checkout@9c091bb

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of other checkout versions in our CI but they come from copier template so it should be updated there

@shree-iyengar-dls shree-iyengar-dls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more potential version update

Comment thread prek.toml Outdated
[[repos]]
repo = "https://github.com/astral-sh/uv-pre-commit"
rev = "0.10.2"
rev = "0.11.26"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZohebShaikh
ZohebShaikh added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit 40c1cdc Jul 7, 2026
20 checks passed
@ZohebShaikh
ZohebShaikh deleted the update-pre-commit-hoos branch July 7, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants