Skip to content

test: Add system test for authorization checks - #1574

Merged
ZohebShaikh merged 110 commits into
mainfrom
add_system_test
Jul 14, 2026
Merged

test: Add system test for authorization checks#1574
ZohebShaikh merged 110 commits into
mainfrom
add_system_test

Conversation

@ZohebShaikh

@ZohebShaikh ZohebShaikh commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes ACQP-553

This PR has the following changes:

  1. Update version of hovercraft
  2. Add two new users alice and bob
  3. Write tests with multiple users

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

tpoliaw and others added 30 commits June 23, 2026 16:38
@tpoliaw
Validate tiled service account configuration at startup
affedf8
@tpoliaw
Add tests for tiled check
0482d81
@tpoliaw
Add opa dependency function to create OpaUserClient
170e3d1
@tpoliaw
test opa dependency function
b3254ea
@tpoliaw
Add can_submit_task auth check method and config
fcad0af
@shree-iyengar-dls @tpoliaw
feat: add authz dependency injection
171de82
@shree-iyengar-dls @tpoliaw
feat: add auth check dependency injections to task endpoints
ddfeab0
@shree-iyengar-dls @tpoliaw
feat: create new access task permission fns and add as dependencies
37524eb
@shree-iyengar-dls @tpoliaw
refactor: update rest api version
13093f6
@shree-iyengar-dls @tpoliaw
comment out dependency addition in set_state
d7d57ae
root @tpoliaw
refactor: add admin check and check to set state function
4ef3365
@tpoliaw
Update dependency names
659cf58
@tpoliaw
Add missing admin check
a669903
@tpoliaw
Handle missing opa and fix tests
d1cb939
@tpoliaw
Remove old admin method
b889e20
@tpoliaw
Use starlette statuses directly
3eb315a
@tpoliaw
test task submission authz
086953f
@tpoliaw
Use _config instead of _conf
2d3a564
@tpoliaw
Re-use instrument session regex
83ae2a6
@tpoliaw
remove task access check
029bc89
@tpoliaw
Add match to raises check
4e12a23
@tpoliaw
Add exception detail
850682b
@tpoliaw
Let admin see all tasks
2f1d3eb
@tpoliaw
Start of api authz tests
e720bc4
@tpoliaw
Make get_tasks async to access authz check
d73d01a
@tpoliaw
Parametrise filter test to check with and without admin
d1b7302
@tpoliaw
Add test for deleting tasks
02eba88
@tpoliaw
Add test for submit without permission
b34600a
@tpoliaw
Test setting other user's task active
6967b16
@tpoliaw
Test getting other users task
49b1b97
@ZohebShaikh ZohebShaikh changed the title Add system test test: Add system test for authorization checks Jul 7, 2026
@ZohebShaikh
ZohebShaikh marked this pull request as ready for review July 8, 2026 09:10
@ZohebShaikh
ZohebShaikh requested a review from a team as a code owner July 8, 2026 09:10
Base automatically changed from add_depedency_injection to main July 14, 2026 08:55
@ZohebShaikh
ZohebShaikh enabled auto-merge July 14, 2026 08:57
@ZohebShaikh
ZohebShaikh disabled auto-merge July 14, 2026 08:57
@ZohebShaikh
ZohebShaikh enabled auto-merge July 14, 2026 09:23
@ZohebShaikh
ZohebShaikh added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit c2e50b5 Jul 14, 2026
20 checks passed
@ZohebShaikh
ZohebShaikh deleted the add_system_test branch July 14, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dan-fernandes dan-fernandes dan-fernandes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZohebShaikh @dan-fernandes @tpoliaw @shree-iyengar-dls