Skip to content

feat: Add host CLI option as alternative to config - #1395

Merged
tpoliaw merged 2 commits into
mainfrom
client-host-option
Apr 30, 2026
Merged

tpoliaw merged 2 commits into
mainfrom
client-host-option

Conversation

@tpoliaw

@tpoliaw tpoliaw commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/blueapi/client/rest.py Resolved
@codecov

codecov Bot commented Feb 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.34%. Comparing base (6cb55c1) to head (8d18bdc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
+ Coverage   95.30%   95.34%   +0.03%     
==========================================
  Files          43       43              
  Lines        3198     3201       +3     
==========================================
+ Hits         3048     3052       +4     
+ Misses        150      149       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw
tpoliaw force-pushed the config-parameters branch 2 times, most recently from c3e9908 to 136df8d Compare February 19, 2026 18:40
Base automatically changed from config-parameters to main February 19, 2026 18:45
Comment thread docs/reference/openapi.yaml Resolved
@tpoliaw tpoliaw changed the title Add host option to remove need for client configuration feat: Add host CLI option as alternative to config Feb 23, 2026
@tpoliaw
tpoliaw marked this pull request as ready for review February 23, 2026 17:47
@tpoliaw
tpoliaw requested a review from a team as a code owner February 23, 2026 17:47
@abbiemery abbiemery self-assigned this Feb 26, 2026

@abbiemery abbiemery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to run scans against tiled 0.2.4 (current state of main) with this I am getting an error from the tiled writer:

TypeError: DataSource.__init__() got an unexpected keyword argument 'properties'

This may be just down to it needing rebasing but does raise the question of if we are clear somewhere about the versions of tiled we support.

Works against 0.2.3. Can login/out, get devices and run plans etc. Happy to approve pending a credential discussion.

Comment thread docs/reference/openapi.yaml Resolved
Comment thread src/blueapi/client/client.py Resolved
@keithralphs

Copy link
Copy Markdown
Contributor

Keep the new CLI option to set the host but remove the stomp config stuff and replace with websocket work

@tpoliaw
tpoliaw force-pushed the client-host-option branch 2 times, most recently from 8d41f65 to b0f3611 Compare March 5, 2026 13:28
@tpoliaw
tpoliaw force-pushed the client-host-option branch from b0f3611 to a17edfd Compare April 8, 2026 13:48
@tpoliaw
tpoliaw requested a review from abbiemery April 22, 2026 15:27
@abbiemery
abbiemery force-pushed the client-host-option branch from a17edfd to 54fe23b Compare April 24, 2026 12:57
@abbiemery

Copy link
Copy Markdown
Contributor

@tpoliaw So as it stands you can look at devices etc with the host option, but can't run plans?

@abbiemery
abbiemery force-pushed the client-host-option branch from 54fe23b to 5936ed3 Compare April 24, 2026 13:07
@tpoliaw

tpoliaw commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

You can run plans in the background but nothing that requires stomp

@abbiemery abbiemery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are being pedantic and not including a scheme with your host: uv run blueapi -H localhost controller plans, it fails loudly demanding a full url.

Image

If we are always using a given scheme, could you add this handling? Otherwise perhaps put an example url in the help. Or rename it url.

Comment thread src/blueapi/cli/cli.py Resolved
@tpoliaw

tpoliaw commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

Have added docs to host command and made -h lower case. The bg plan docs have gone in a new PR as they're not really related to host: #1515

@abbiemery
abbiemery force-pushed the client-host-option branch from 19ead6d to 8d18bdc Compare April 30, 2026 09:29
@tpoliaw
tpoliaw merged commit 4d7c799 into main Apr 30, 2026
19 checks passed
@tpoliaw
tpoliaw deleted the client-host-option branch April 30, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants