Repository navigation
Core: declare data() getter, each/filter/not arguments in the d.ts - #35871
Merged
pharret31 merged 4 commits intoOct 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The deferred predicates expose writable methods on accepted read-only promises, allowing type-checked calls that fail at runtime.
No open issues 🎉
What changed in this PR
This PR updates DevExtreme’s core TypeScript declarations to better represent renderer methods and deferred detection, then removes type-error suppressions made unnecessary by those changes.
Changes:
- Add a generic
data()getter and broadeneach,filter, andnotsignatures. - Add
isDeferredtype predicates to public and internal declarations. - Update affected internal types and remove obsolete suppression comments.
| File | Description |
|---|---|
| packages/devextreme/ts/dx.all.d.ts | Synchronizes bundled renderer declarations. |
| packages/devextreme/js/core/utils/type.d.ts | Declares the public deferred type guard. |
| packages/devextreme/js/core/renderer.d.ts | Updates getter and callback signatures. |
| packages/devextreme/js/__internal/ui/toolbar/toolbar.base.ts | Removes an each suppression. |
| packages/devextreme/js/__internal/ui/themes.ts | Removes an each suppression. |
| packages/devextreme/js/__internal/ui/splitter/utils/component.ts | Types component-name data and adjusts suppression. |
| packages/devextreme/js/__internal/ui/scroll_view/scrollable.simulated.ts | Removes a comparison suppression. |
| packages/devextreme/js/__internal/ui/responsive_box.ts | Removes a data-getter suppression. |
| packages/devextreme/js/__internal/ui/overlay/overlay.ts | Removes an iteration suppression. |
| packages/devextreme/js/__internal/ui/multi_view/multi_view.ts | Removes iteration suppressions. |
| packages/devextreme/js/__internal/ui/html_editor/utils/table_helper.ts | Removes an each suppression. |
| packages/devextreme/js/__internal/ui/html_editor/modules/tableResizing.ts | Removes iteration suppressions. |
| packages/devextreme/js/__internal/ui/form/components/field_item.ts | Removes a data-getter suppression. |
| packages/devextreme/js/__internal/ui/diagram/ui.diagram.toolbox.ts | Removes an each suppression. |
| packages/devextreme/js/__internal/ui/context_menu/menu_base.ts | Removes filter and data suppressions. |
| packages/devextreme/js/__internal/ui/calendar/calendar.ts | Removes a date-data suppression. |
| packages/devextreme/js/__internal/ui/calendar/calendar.base_view.ts | Adjusts action argument types and removes suppressions. |
| packages/devextreme/js/__internal/ui/button_group.ts | Removes an item-index suppression. |
| packages/devextreme/js/__internal/ui/accordion.ts | Uses the generic data getter. |
| packages/devextreme/js/__internal/sortable.ts | Removes getter and iteration suppressions. |
| packages/devextreme/js/__internal/scheduler/m_compact_appointments_helper.ts | Removes an appointment-data suppression. |
| packages/devextreme/js/__internal/grids/pivot_grid/field_chooser/m_field_chooser.ts | Types retrieved field data. |
| packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/m_virtual_scrolling.ts | Removes an each suppression. |
| packages/devextreme/js/__internal/grids/grid_core/views/columns_view.ts | Removes row and form-data suppressions. |
| packages/devextreme/js/__internal/grids/grid_core/validating/m_validating.ts | Removes an iteration suppression. |
| packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts | Removes a filter-callback suppression. |
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts | Removes a wrapper-filter suppression. |
| packages/devextreme/js/__internal/grids/grid_core/context_menu/m_context_menu.ts | Removes a row-data suppression. |
| packages/devextreme/js/__internal/grids/grid_core/column_state_mixin/column_state_mixin.ts | Removes a row-data suppression. |
| packages/devextreme/js/__internal/grids/grid_core/adaptivity/adaptivity.ts | Removes a form-item data suppression. |
| packages/devextreme/js/__internal/draggable.ts | Removes a scrollable-data suppression. |
| packages/devextreme/js/__internal/core/utils/m_type.ts | Adds the internal deferred type predicate. |
| packages/devextreme/js/__internal/core/utils/m_dom.ts | Removes a filter-callback suppression. |
| packages/devextreme/js/__internal/common/core/animation/fx.ts | Uses typed animation data and removes suppression. |
Review effort: Balanced
pharret31
force-pushed
the
typescript/core/element_wrapper_dts
branch
from
October 22, 2026 15:42
27c1c8c to
809a69e
Compare
pharret31
force-pushed
the
typescript/core/element_wrapper_dts
branch
2 times, most recently
from
October 22, 2026 16:46
b956a95 to
fe3c96e
Compare
pharret31
force-pushed
the
typescript/core/element_wrapper_dts
branch
from
October 22, 2026 17:42
fe3c96e to
c849f5e
Compare
pharret31
force-pushed
the
typescript/core/element_wrapper_dts
branch
from
October 22, 2026 18:22
c849f5e to
c454be4
Compare
pharret31
force-pushed
the
typescript/core/element_wrapper_dts
branch
from
October 22, 2026 18:35
c454be4 to
e45b523
Compare
pharret31
changed the title
pharret31
force-pushed
the
typescript/core/element_wrapper_dts
branch
2 times, most recently
from
October 23, 2026 10:33
e45b523 to
deeb5db
Compare
…ot() of the dxElementWrapper d.ts
…derer as jQuery does
pharret31
force-pushed
the
typescript/core/element_wrapper_dts
branch
from
October 23, 2026 10:37
deeb5db to
d4f90c0
Compare
EugeniyKiyashko
approved these changes
Oct 23, 2026
sjbur
approved these changes
Oct 23, 2026
anna-shakhova
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.