Repository navigation
Unused let in the LINQ expression changes result of Query #402
Description
(from invoice in Session.Query.All<Invoice>()
let foo = invoice.InvoiceId.In(nonExistingIds) // This line incorrectly works as additional filter.
// Must not have any impact
where invoice.InvoiceId.In(existingIds)
select invoice).Count();
The expression:
{All().Select(invoice => new <>f__AnonymousType231`2(invoice = invoice, foo = invoice.InvoiceId.In(value(Xtensive.Orm.Tests.Linq.InTest+
<>c__DisplayClass37_0).nonExistingIds))).Where(<>h__TransparentIdentifier0 =>
<>h__TransparentIdentifier0.invoice.InvoiceId.In(value(Xtensive.Orm.Tests.Linq.InTest+<>c__DisplayClass37_0).existingIds)).Select(<>h__TransparentIdentifier0 => <>h__TransparentIdentifier0.invoice)}
The test to reproduce it:
https://github.com/DataObjects-NET/dataobjects-net/pull/401/files
Looks like let works as where filter.
It is a simlified example.
In the real app we discovered the same effect with used variable in let.
We thought the behavior changed after merging https://github.com/dataObjects-net/dataobjects-net commits for last 7 months.
But after some investigation I see the bug is here for longer time, may be from the beginning.
Activity
[-]Unused `let` in the LINQ expression makes query incorrect[/-][+]Unused `let` in the LINQ expression changes result of Query[/+]Fix DataObjects-NET#402:
Revert "Fix DataObjects-NET#402:"
Disable `RedundantColumnOptimizer` as a workaround of `.In()` in `let…
alex-kulakov commentedon Dec 4, 2024
Two problems were discovered during investigation of this case
First issue appeared after changes released in 6.0.13 and traversed to newer branches via merge.
@SergeiPavlov the PR that fixes both of issues, and because root of at least one of problems lied in 6.0 branch I had to resolve it there. Soon these changes will be merged into newer branches
Merge pull request #405 from DataObjects-NET/6.0-include-related-issues